Skip to content

Fix missaligned snapping crosshair due to broken property binding#4601

Open
Withalion wants to merge 4 commits into
masterfrom
bugfix/missaligned-snapping-crosshair
Open

Fix missaligned snapping crosshair due to broken property binding#4601
Withalion wants to merge 4 commits into
masterfrom
bugfix/missaligned-snapping-crosshair

Conversation

@Withalion

Copy link
Copy Markdown
Collaborator

After migrating to newer Qt version recording crosshair didn't properly snap to vertices etc. This PR fixes the issue and after the crosshair snaps to vertex, it remains "sticky" for a small distance.

Old

screen-20260626-103045-1782462623918.mp4

New

Screencast_20260714_190952.mp4

Thanks @harminius for catching this :)

@Withalion
Withalion requested a review from tomasMizera July 14, 2026 17:15
@Withalion Withalion self-assigned this Jul 14, 2026
@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build Build failed or not found. #7026
linux Build 📬 Mergin Maps 70521 x86_64 Expires: 12/10/2026 #7052
win64 Build 📬 Mergin Maps 62281 win64 Expires: 12/10/2026 #6228
Android Build 📬 Mergin Maps 833651 APK [arm64-v8a] Expires: 12/10/2026 #8336
📬 Mergin Maps 833651 APK [arm64-v8a] Google Play Store #8336
Android Build 📬 Mergin Maps 833611 APK [armeabi-v7a] Expires: 12/10/2026 #8336
📬 Mergin Maps 833611 APK [armeabi-v7a] Google Play Store #8336
iOS Build 📬 Build number: 26.07.927811 #9278

Comment thread app/qml/map/components/MMCrosshair.qml Outdated
@Withalion Withalion added this to the 2026.3.1 milestone Jul 15, 2026
@Withalion
Withalion force-pushed the bugfix/missaligned-snapping-crosshair branch from 12d1e8f to 69a083d Compare July 16, 2026 13:36
@github-actions

Copy link
Copy Markdown

Coverage Report for CI Build 29502904910

Warning

No base build found for commit 7de4002 on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 59.086%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15645
Covered Lines: 9244
Line Coverage: 59.09%
Coverage Strength: 97.77 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 70331 dmg Expires: 14/10/2026 #7033
linux Build 📬 Mergin Maps 70591 x86_64 Expires: 14/10/2026 #7059
win64 Build 📬 Mergin Maps 62351 win64 Expires: 14/10/2026 #6235
Android Build Build failed or not found. #8343
iOS Build 📬 Build number: 26.07.928511 #9285

@Withalion
Withalion requested a review from tomasMizera July 16, 2026 16:43
@github-actions

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build 📬 Mergin Maps 70341 dmg Expires: 14/10/2026 #7034
linux Build Build failed or not found. #7060
win64 Build 📬 Mergin Maps 62361 win64 Expires: 14/10/2026 #6236
Android Build 📬 Mergin Maps 834411 APK [armeabi-v7a] Expires: 14/10/2026 #8344
📬 Mergin Maps 834411 APK [armeabi-v7a] Google Play Store #8344
Android Build 📬 Mergin Maps 834451 APK [arm64-v8a] Expires: 14/10/2026 #8344
📬 Mergin Maps 834451 APK [arm64-v8a] Google Play Store #8344
iOS Build 📬 Build number: 26.07.928611 #9286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants