Fix disappearing bg and wrong padding on widnows for reset button#4602
Open
xkello wants to merge 1 commit into
Open
Fix disappearing bg and wrong padding on widnows for reset button#4602xkello wants to merge 1 commit into
xkello wants to merge 1 commit into
Conversation
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The filter reset button's background was disappearing on hover. This caused inconsistent behavior between platforms, since mobile devices did not exhibit this issue.
What changed
Added
bgndColorHoverandfontColorHoverto the action button, sincetype: Tertiaryhad its own styling that was overriding the defaults on hover. Explicitly setting these values aligns desktop behavior with mobile.Swapped the order of the
ifstatements. Previously,type: Tertiarywas checked beforesize: ExtraSmall, causing the margin to be set to0instead of the intended value. Since margins were handled per-platform rather than in shared code, this meant the button had correct margins on mobile but appeared as a circle instead of a pill shape on Windows.Behaviour
The button no longer has hover-specific styling logic, so the background no longer disappears on mouse hover. Margins are also fixed, giving the action button its intended pill shape.