Fix literal wildcards in text filters#4609
Draft
floze-the-genius wants to merge 1 commit into
Draft
Conversation
Escape LIKE metacharacters in user-entered text and cover percent, underscore, escape-character, and combined inputs against an OGR GeoPackage layer. Assisted-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!,%, and_before substituting text filter values intoLIKEexpressionsESCAPE '!'clause so%and_are matched literally while the surrounding%...%still performs substring matching%_inputRoot cause
Text filter values were quoted for SQL string safety, but SQL
LIKEmetacharacters were left unchanged. As a result,%matched any sequence and_matched any single character instead of the characters users typed.Closes #4517.
Validation
astylecheck on all changed C++/header filesgit diff --checkLIKE ... ESCAPE '!'patterns for%,_,!, and%_roads.gpkgthrough the OGR providerThe full Mergin Maps native test binary was not built locally because this host does not have the repository's Qt/QGIS/vcpkg toolchain.
AI assistance disclosure
OpenAI Codex assisted with issue triage, implementation, regression-test drafting, and validation. The contribution was reviewed against the repository policies and the generated SQL behavior was independently checked locally.