fix(settings): JSON-encode plant timezone so saving works on PostgreSQL - #277
Merged
Conversation
…greSQL
TimezoneRegistry wrote the raw identifier into system_settings.value, which is a
JSON column — PostgreSQL rejects a bare string ('invalid input syntax for type
json'), 500-ing every Settings → System save. SQLite tolerated it, so the suite
(and an assertion that pinned the raw value) missed it. Encode on write, decode on
read (tolerating a legacy raw value), and flip the test to expect JSON storage.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving system settings 500s on PostgreSQL
TimezoneRegistry::save()wrote the raw timezone identifier (e.g.Europe/Warsaw) straight intosystem_settings.value— a JSON column. PostgreSQL rejects a bare string:so every Settings → System save 500s on a Postgres install (the default Docker deployment). SQLite stores it as text, so the suite passed — and an existing test even asserted the raw value and warned against
json_encode, locking the bug in.Fix
save()→json_encode($timezone)(valid JSON for the column).stored()→json_decode(...), tolerating a legacy raw value.SystemSettingsTimezoneTestto expect JSON storage + round-trip.Verified live on a PostgreSQL box (save + read round-trip) and the full suite is green (2528).
🤖 Generated with claude-flow