fix(settings): language picker follows the active locale (#271) - #278
Merged
Conversation
The Settings → System language dropdown read only the stored system-default language, so after changing the UI language with the per-session switcher the picker showed a different language than the page was rendered in. Show the currently effective locale (session override if set, else the system default) so the picker matches what the user sees. Closes #271.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…age-picker # Conflicts: # CHANGELOG.md
WorkstationFactory generated a random 3-letter code (WS-???, only 26^3 = 17,576 values), so a run that created several workstations could hit the workstations.code unique index by chance (UniqueConstraintViolationException in MachineCountToProducedQtyTest). Add faker unique() so the code can never repeat. Unrelated to the language fix; it was a pre-existing CI flake surfaced here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271.
The language picker showed a different language than the page
Settings → System → Language read only the stored system-default language (
system_settings.language). But the page itself renders in the currently effective locale — the per-session override set by the language switcher (/locale/{locale}), falling back to the system default. So after switching the UI to English, the picker still showed Polski, contradicting the English page.Reproduced on a local box:
/locale/en→ the whole UI is English, but the picker read "Polski". After the fix it reads "English".Fix
SettingsControllernow sources the picker fromapp()->getLocale()(the locale SetLocale already applied for the request) instead of the raw system-default row, so the picker always matches the language on screen. Added a regression test (system defaultpl+ session overrideen→ picker showsen).🤖 Generated with claude-flow