Skip to content

Fix missing close macro in MSYS2#629

Open
currocam wants to merge 2 commits into
MesserLab:masterfrom
currocam:fix/mingw64-gcc16-close-macro
Open

Fix missing close macro in MSYS2#629
currocam wants to merge 2 commits into
MesserLab:masterfrom
currocam:fix/mingw64-gcc16-close-macro

Conversation

@currocam
Copy link
Copy Markdown
Contributor

@currocam currocam commented May 16, 2026

Attempt to fix #627

An alternative implementation is in the first commit. I wonder if adding -DGNULIB_ to all source files would be simpler instead of growing the existing list.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.72%. Comparing base (4f77dd5) to head (724b1ca).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
+ Coverage   75.69%   75.72%   +0.03%     
==========================================
  Files         114      114              
  Lines       75550    72808    -2742     
  Branches    12876    12870       -6     
==========================================
- Hits        57184    55132    -2052     
+ Misses      18366    17676     -690     

see 85 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows builds, both CLI and GUI, now failing for unclear reason

1 participant