#979 Initial util code for grid names - #1004
Draft
Jared Drayton (mo-jareddrayton) wants to merge 1 commit into
Draft
#979 Initial util code for grid names#1004Jared Drayton (mo-jareddrayton) wants to merge 1 commit into
Jared Drayton (mo-jareddrayton) wants to merge 1 commit into
Conversation
| from cdds.utils.grid_labels.parsers import parse_icemod_grids, parse_ocean_grids | ||
| from cdds.utils.grid_labels.stashmaster import stash_records | ||
|
|
||
| grid_name_to_grid_id = { |
Collaborator
There was a problem hiding this comment.
mention that this relates to STASH entries
Comment on lines
+106
to
+109
| if variable in seaice_grids and variable not in seaice: | ||
| grid_name = "tripolar-native" | ||
| if variable in seaice: | ||
| grid_name = seaice[variable] |
Collaborator
There was a problem hiding this comment.
Consider searching expression for apply_ocean_coordinates to identify sea ice variables that are not on T points
Matthew Mizielinski (matthew-mizielinski)
left a comment
Matthew Mizielinski (matthew-mizielinski)
left a comment
Collaborator
There was a problem hiding this comment.
Other than docstrings looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #979