Support for unstructured regional ML gridded data - #2106
Closed
James Warner (jwarner8) wants to merge 51 commits into
Closed
Support for unstructured regional ML gridded data#2106James Warner (jwarner8) wants to merge 51 commits into
James Warner (jwarner8) wants to merge 51 commits into
Conversation
Contributor
Total coverage: 93% (HTML report)Name Stmts Miss Branch BrPart Cover --------------------------------------------------------------------------------------------------- src/CSET/__init__.py 104 0 14 0 100% src/CSET/_common.py 150 0 52 0 100% src/CSET/cset_workflow/app/fetch_fcst/bin/fetch_data.py 117 28 26 0 78% src/CSET/cset_workflow/app/fetch_nimrod/bin/fetch_nimrod.py 81 8 28 11 83% src/CSET/cset_workflow/app/finish_website/bin/finish_website.py 79 2 8 2 95% src/CSET/cset_workflow/app/parbake_recipes/bin/parbake.py 29 0 8 0 100% src/CSET/cset_workflow/app/send_email/bin/send_email.py 25 0 4 0 100% src/CSET/cset_workflow/lib/python/jinja_utils.py 17 0 6 0 100% src/CSET/extract_workflow.py 103 1 26 1 98% src/CSET/graph.py 44 0 14 0 100% src/CSET/operators/__init__.py 89 0 26 0 100% src/CSET/operators/_atmospheric_constants.py 9 0 0 0 100% src/CSET/operators/_colormaps.py 249 3 72 4 98% src/CSET/operators/_stash_to_lfric.py 3 0 0 0 100% src/CSET/operators/_utils.py 190 8 72 6 95% src/CSET/operators/ageofair.py 142 7 64 5 94% src/CSET/operators/aggregate.py 77 1 22 1 98% src/CSET/operators/aviation.py 61 0 18 0 100% src/CSET/operators/collapse.py 155 8 72 3 93% src/CSET/operators/constraints.py 113 7 50 3 93% src/CSET/operators/convection.py 38 4 10 2 88% src/CSET/operators/ensembles.py 27 0 14 0 100% src/CSET/operators/feature.py 44 0 10 0 100% src/CSET/operators/filters.py 67 2 30 0 98% src/CSET/operators/fluxes.py 41 0 10 0 100% src/CSET/operators/humidity.py 135 0 52 0 100% src/CSET/operators/imageprocessing.py 57 0 16 0 100% src/CSET/operators/mesoscale.py 18 0 2 0 100% src/CSET/operators/misc.py 172 1 72 3 98% src/CSET/operators/plot.py 1120 153 394 66 83% src/CSET/operators/power_spectrum.py 98 3 30 3 95% src/CSET/operators/precipitation.py 204 2 92 2 99% src/CSET/operators/pressure.py 41 0 12 0 100% src/CSET/operators/read.py 436 21 186 15 94% src/CSET/operators/regrid.py 237 1 94 3 99% src/CSET/operators/scoreswrappers.py 160 22 40 7 82% src/CSET/operators/temperature.py 121 0 32 0 100% src/CSET/operators/transect.py 63 0 24 0 100% src/CSET/operators/wind.py 46 3 10 2 91% src/CSET/operators/write.py 15 0 6 0 100% src/CSET/recipes/__init__.py 104 0 28 0 100% --------------------------------------------------------------------------------------------------- TOTAL 5081 285 1746 139 93% |
James Frost (jfrost-mo)
changed the title
Contributor
Author
|
Have this working in the workflow, but aggregation very slow... there is a question of whether there is a better way, as we are regridding the data again in every baked recipe... over a 100 times. |
Contributor
Author
Need to check how nan is propagated, given stats values showing np.nan
|
Contributor
Author
|
Have lock files working now, just need to implement tests... |
Contributor
Author
|
Building in Anke F (@afinnen) suggestion for passing constraint all the way through to regrid, rather than backing out varname and others from an object for a much nicer implementation. |
Contributor
Author
|
Now working on ensuring pre-fix of metadata keeps data lazy, otherwise becomes memory expensive. Seems to work using |
Contributor
Author
|
Outstanding issues, that might require their own issues to solve:
|
James Warner (jwarner8)
marked this pull request as ready for review
June 30, 2026 12:14
Contributor
Author
|
This is probably ready for a review, as a not quite polished PR, in order to get any feedback from other developers. A practical balance has been sought over general flexibility and dealing with specific format data coming out of Anemoi. |
Contributor
Author
|
Following discussion at CSET surgery, might be worth holding off this PR till we have a contrib or similar scripts folder, but general logic could be useful to review. |
James Warner (jwarner8)
removed the request for review
from James Frost (jfrost-mo)
July 7, 2026 10:30
James Warner (jwarner8)
marked this pull request as draft
July 28, 2026 14:47
6 tasks
Contributor
Author
|
Closing this pull request as superseeded by #2370. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #1975 and enables us to use CSET with regional ML models (BRIS, Regional FastNet).
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.