-
Notifications
You must be signed in to change notification settings - Fork 18
Add Scores diagnostics for spatial and timeseries RMSE, Additive Bias, MAE, and Pearson’s Correlation Coefficient #2232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
125 commits
Select commit
Hold shift + click to select a range
09490d1
Loaders for new Scores metrics #2214
BernardClaxton 63e12f5
Recipe for 20d spatial plots of scores metrics #2214
BernardClaxton 68ee904
Recipe for 2-d timeseries plots of scores metrics #2214
BernardClaxton 4ba0e65
Operator for scores metrics #2214
BernardClaxton 7229736
Rose GUI edits for scorer metrics #2214
BernardClaxton ab7c205
Tidy loaders for scorer metrics #2214
BernardClaxton 6100386
Tidy recipe for spatial plots of scorer metrics #2214
BernardClaxton 81b21dc
Tidy recipe for timeseries plots of scorer metrics #2214
BernardClaxton f136481
Tidy operator for scorer metrics #2214
BernardClaxton 0d2a5d5
Tidy comments in operator for scorer metrics #2214
BernardClaxton 67dcd2d
Changed the Rose GUI for the scores metrics #2214
BernardClaxton a658473
Changed the scores loaders to reflect the Rose GUI redesign #2214
BernardClaxton 391574d
Tidied the logic in scores loaders #2214
BernardClaxton a66c7ad
Added scores Pearson Correlation timeseries to Rose GUI #2214
BernardClaxton 91277e4
Added scores Pearson Correlation timeseries to loader #2214
BernardClaxton f9ebf3f
Removed bmc from titles of spatial plots #2214
BernardClaxton d7de101
Removed bmc from titles of timeseries plots #2214
BernardClaxton 28865fe
Removed legacy RMSE scores loaders #2214
BernardClaxton c171e9c
Tests for the scores code #2214
BernardClaxton bb5ba3f
Updated rose-suite.conf.example with the scores variables #2214
BernardClaxton 0a3c96f
Removing redundant variables from rose-suite.conf.example #2214
BernardClaxton d214288
Merge remote-tracking branch 'origin/main' into 2214_adding_scores
BernardClaxton 9358351
Apply suggestion from @jfrost-mo
BernardClaxton 3f4256a
Apply suggestion from @jfrost-mo
BernardClaxton 8894a87
Apply suggestion from @jfrost-mo
BernardClaxton f3899db
Apply suggestion from @jfrost-mo
BernardClaxton e4a7650
Apply suggestion from @jfrost-mo
BernardClaxton 11445b8
Apply suggestion from @jfrost-mo
BernardClaxton 6722245
Apply suggestion from @jfrost-mo
BernardClaxton 06f201d
Merge branch 'main' into 2214_adding_scores
BernardClaxton 6889879
Applying change to from docstring to regular comment #2214
BernardClaxton 8d09a91
Redrafted to use match statment to select the scores method #2214
BernardClaxton 1eab769
Re-committing rose-meta.conf #2214
BernardClaxton b7bb8e1
Minor comment change #2214
BernardClaxton 5282d67
Modified loaders for scores metrics #2214
BernardClaxton 9b90b0a
Recipe for spatial scores RMSE #2214
BernardClaxton 1b35d18
Recipe for spatial scores MAE #2214
BernardClaxton 52238e5
Recipe for spatial scores additive bias #2214
BernardClaxton f9a9c94
Recipe for timeseries scores pearsons correlation #2214
BernardClaxton f92575d
Recipe for timeseries scores additive bias #2214
BernardClaxton c657605
Recipe for timeseries scores MAE #2214
BernardClaxton cb7160a
Recipe for timeseries scores RMSE #2214
BernardClaxton c9485c4
Minor change to a recipe description #2214
BernardClaxton 63a1e92
Unit test for MAE in scoreswrapper.py #2214
BernardClaxton 16c585e
Unit test for additive bias in scoreswrapper.py #2214
BernardClaxton 8175fdd
Unit test for Pearson correlation in scoreswrapper.py #2214
BernardClaxton 6cb2e24
Unit test for MAE scores_method in scoreswrapper.py #2214
BernardClaxton 1604e4b
Unit test for RMSE scores_method in scoreswrapper.py #2214
BernardClaxton 1e6c227
Unit test for additive bias scores_method in scoreswrapper.py #2214
BernardClaxton 783cb32
Unit test for Pearson correlation scores_method in scoreswrapper.py …
BernardClaxton 92c166e
Unit test for unknown metric scores_method in scoreswrapper.py #2214
BernardClaxton 66ed715
Removed rouge test file ~/CSET/src/CSET/tests/test_scoreswrappers.py …
BernardClaxton a65da5e
Removed rogue test file ~/CSET/src/CSET/tests/test_verification.py #…
BernardClaxton ebdcd48
Merge branch 'main' into 2214_adding_scores
BernardClaxton 49f285d
Added SATURATION_FRACTION to rose-suite.conf.example #2214
BernardClaxton 8c1a5b7
Setting SATURATION_FRACTION to False #2214
BernardClaxton 59df88f
Removed SCORES_METHOD from spatial scores loader #2214
BernardClaxton 953e5a7
Hardwired the MAE scores method into this recipe #2214
BernardClaxton d0e1950
Hardwired the RMSE scores method into spatial scores RMSE recipe #2214
BernardClaxton 2f055ef
Hardwired the ME scores method into spatial scores ME recipe #2214
BernardClaxton 5a4921e
Removed SCORES_METHOD from timeseries scores loader #2214
BernardClaxton c464d72
Hardwired the MAE scores method into timeseries scores MAE recipe #2214
BernardClaxton 1c28ad3
Hardwired the RMSE scores method into timeseries scores RMSE recipe …
BernardClaxton 34fcf47
Hardwired the ME scores method into timeseries scores ME recipe #2214
BernardClaxton 3b23972
Hardwired the Pearsons Correlation scores method into timeseries scor…
BernardClaxton 5b1683e
Tidying the timeseries scores Pearson Correlation recipe #2214
BernardClaxton 416da34
Tidying the timeseries score MAE recipe #2214
BernardClaxton 63a1262
Tidying the timeseries score RMSE recipe #2214
BernardClaxton 906c6ce
Tidying the timeseries score ME recipe #2214
BernardClaxton f9ccd31
Removed function scores_metrics #2214
BernardClaxton d6c765f
Removed tests for function scores_metrics #2214
BernardClaxton e78d55a
Trialling new time coords #2214
BernardClaxton 67f63e4
New recipe to mean over scores RMSE #2214
BernardClaxton be9aba0
Loader to mean over scores RMSE #2214
BernardClaxton 97a5005
Operator to mean over scores RMSE #2214
BernardClaxton 053456c
Put into scores spatial recipe #2214
BernardClaxton 3552a04
Tidied scores spatial loader #2214
BernardClaxton ad49673
Updates to verification.py #2214
BernardClaxton 846f16a
Updates scores RMSE recipe #2214
BernardClaxton 08245d5
Updated the scores RMSE spatial plot recipe description #2214
BernardClaxton 2ff9050
Scores operator now implements correct averaging MAE over a case stud…
BernardClaxton 44ab662
Scores loader now implements correct averaging MAE over a case study …
BernardClaxton 0a2d373
Scores spatial plot recipe now implements correct averaging MAE over …
BernardClaxton 838bba3
adding conversion from iris to xarray dimension coordinates to all sc…
Sylviabohnenstengel eb11c39
scoreswrapper typo correction.
Sylviabohnenstengel 06da2fc
Support for spatial case averaging in scores loaders #2214
BernardClaxton 6a30b3c
Support for spatial case averaging in scores MAE recipe #2214
BernardClaxton 08a614d
Support for spatial case averaging in scores ME recipe #2214
BernardClaxton f678497
Support in scores loaders for SUBAREA_NAME #2214
BernardClaxton eb1240a
Support in scores spatial MAE recipe for SUBAREA_NAME #2214
BernardClaxton 0c01120
Support in scores spatial RMSE recipe for SUBAREA_NAME #2214
BernardClaxton be12c87
Support in scores spatial ME recipe for SUBAREA_NAME #2214
BernardClaxton 4050da6
Support in scores timeseries MAE recipe for SUBAREA_NAME #2214
BernardClaxton d039477
Support in scores timeseries RMSE recipe for SUBAREA_NAME #2214
BernardClaxton 160795b
Support in scores timeseries ME recipe for SUBAREA_NAME #2214
BernardClaxton fe1881e
Support in scores timeseries persons correlation recipe for SUBAREA_N…
BernardClaxton 286c05f
Added SPATIAL_SCORES_FIELD_METHOD into spatial scores GUI #2214
BernardClaxton 251d5a8
Added SPATIAL_SCORES_FIELD_METHOD into spatial scores loaders #2214
BernardClaxton a29b37f
Update src/CSET/loaders/verification.py
BernardClaxton 46d41a5
Update src/CSET/operators/scoreswrappers.py
BernardClaxton 6f5698e
Update src/CSET/recipes/verification/surface_difference_scores_additi…
BernardClaxton 2e6afc7
Update src/CSET/recipes/verification/surface_difference_scores_additi…
BernardClaxton cdd35b0
Merge branch 'main' into 2214_adding_scores
BernardClaxton 308068b
Updated rose-suite.conf.example with SPATIAL_SCORES_FIELD_METHOD #2214
BernardClaxton 08ed06c
Tidied the scores metrics descriptions in rose-meta.conf #2214
BernardClaxton b170bbb
Merge branch 'main' into 2214_adding_scores
BernardClaxton 90d7f48
Removed spurious return from scores_correlation_pearsonr #2214
BernardClaxton 94e6dd6
Improved description of averaging in scores MAE 2d plot #2214
BernardClaxton 22fcdd2
Improved description of averaging in scores RMSE 2d plot #2214
BernardClaxton 7d54bcb
Improved description of averaging in scores ME 2d plot #2214
BernardClaxton 0400586
Improved description of averaging in scores MAE timeseries plot #2214
BernardClaxton 621bd7d
Improved description of averaging in scores RMSE timeseries plot #2214
BernardClaxton 137c325
Improved description of averaging in scores ME timeseries plot #2214
BernardClaxton d75820f
Improved description of averaging in scores Pearson Correlation times…
BernardClaxton e5d1d24
Merge branch 'main' into 2214_adding_scores
BernardClaxton 41eb73d
Minor tidy of scores recipe #2214
BernardClaxton c92675a
Removed redundant function scores_metrics from testing #1759
BernardClaxton 5237944
Typo in scores metrics testing of cube names #1759
BernardClaxton 7024b25
Typo in scores metrics testing of cube names #1759
BernardClaxton 611b7d4
More detail in docstrings for scores methods in scoreswrappers.py #2214
BernardClaxton 1106bb1
Removed input cubes from test test_scores_rmse_nonzero #2214
BernardClaxton e3f7b7c
Minor typo in description of recipe corrected #2214
BernardClaxton 630e526
Apply suggestion from @jfrost-mo
BernardClaxton a9f9268
Merge branch 'main' into 2214_adding_scores
BernardClaxton f88f923
Merge branch 'main' into 2214_adding_scores
BernardClaxton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.