Skip to content

Fix handling of SCORES_CATEGORICAL_POD_ENTRIES and disable by default in example configuration #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
James Warner (jwarner8) merged 2 commits into from
Aug 20, 2026
+14 −3
Merged

Fix handling of SCORES_CATEGORICAL_POD_ENTRIES and disable by default in example configuration #2401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f7437a
Fix default value for SCORES_CATEGORICAL_POD
jfrost-mo Aug 20, 2026
9244a8e
Skip invalid entries in SCORES_CATEGORICAL_POD_ENTRIES
jfrost-mo Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/CSET/cset_workflow/rose-suite.conf.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ POINT_OBS=False
!!POINT_OBS_USE_WMO_STATION_NUMBERS=False
!!POINT_OBS_WMO_BLOCK_STTN_NUMBERS=[]
PRESSURE_LEVELS=[]
SCORES_CATEGORICAL_POD=True
SCORES_CATEGORICAL_POD_ENTRIES=[""]
SCORES_CATEGORICAL_POD=False
!!SCORES_CATEGORICAL_POD_ENTRIES=[]
PRESSURE_LEVEL_FIELDS=[]
!!PROB_TEMPERATURE_CONDITION=[]
!!PROB_TEMPERATURE_THRESHOLD=[]
Expand Down
13 changes: 12 additions & 1 deletion src/CSET/loaders/verification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,12 @@
"""Load verification recipes."""

import itertools
import logging

from CSET.recipes import Config, RawRecipe, get_models

logger = logging.getLogger(__name__)


def _get_scores_spatial_methods(conf):
"""Compile list of the required scores spatial plots."""
Expand Down Expand Up @@ -290,7 +293,15 @@ def load(conf: Config):
for field_and_method, scores_method in itertools.product(
conf.SCORES_CATEGORICAL_POD_ENTRIES, scores_timeseries_categorical
):
var, op, value = field_and_method.split(",")
try:
var, op, value = field_and_method.split(",")
except ValueError as err:
logger.exception(
f"Invalid value in SCORES_CATEGORICAL_POD_ENTRIES: {field_and_method}",
exc_info=err,
)
# Skip invalid entry.
continue

yield RawRecipe(
recipe=f"surface_categorical_model_obs_{scores_method}.yaml",
Expand Down