#594 Added command line options to skip checkouts or stop after checkout - #595
Open
Joerg Henrichs (hiker) wants to merge 4 commits into
Open
#594 Added command line options to skip checkouts or stop after checkout#595Joerg Henrichs (hiker) wants to merge 4 commits into
Joerg Henrichs (hiker) wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
cla-required
github-actions
Bot
added
cla-signed
allynt
requested changes
Aug 20, 2026
Comment on lines
+475
to
+485
| parser.add_argument( | ||
| '--checkout-only', action="store_true", default=False, | ||
| help=("Only do the checkout steps, not any actual build steps." | ||
| "This can be useful if checkout and compilation steps " | ||
| "need to run on different nodes.")) | ||
| parser.add_argument( | ||
| '--skip-checkout', action="store_true", default=False, | ||
| help=("Do not do any checkouts. This flag can be used if a " | ||
| "checkout was already done, to just do the compilation. " | ||
| "This is useful if checkout and compilation needs to be " | ||
| "done on different nodes.")) |
Contributor
There was a problem hiding this comment.
These 2 options are mutually exclusive. Is it worth explicitly marking them as such? Something along the lines of:
checkout_group = parser.add_mutually_exclusive_group()
checkout_group.add_argument('--checkout-only', action="store_true", default=False)
checkout_group.add_argument('--skip-checkout', action="store_true", default=False)
Otherwise, you can add an explicit check in handle_command_line_options. Something along the lines of:
if self.args.checkout_only and self.args.skip_checkout:
raise RuntimeError(f"--checkout-only and --skip-checkout are mutually exclusive arguments")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rather small change. It requires changes in the actual application scripts (since they are the ones actually doing any git/svn/... checkout). I've tested this with lfric_atm.