Add jules-lfric metadata - #110
Conversation
Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
Maggie (maggiehendry)
left a comment
There was a problem hiding this comment.
https://github.com/MetOffice/jules/blob/main/.github/CODEOWNERS will need jules-lfric added.
Good point, that's done |
| # This file in the future will reside in the JULES repository and will import | ||
| # jules-shared directly from there when the build system has been developed to | ||
| # allow this. | ||
| # |
There was a problem hiding this comment.
| # | |
| # This file is imported by jules-lsm in the LFRic apps repository. |
This one also needs changing.
There was a problem hiding this comment.
James Bruten (@james-bruten-mo) the change went awry.
Maggie (maggiehendry)
left a comment
There was a problem hiding this comment.
vn8.1 needs changing like HEAD.
Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
|
I've just updated the PR Template question reminding for the need of a linked PR when jules-shared is changed |
Maggie (maggiehendry)
left a comment
There was a problem hiding this comment.
It would appear that I forgot to submit this one earlier.
| # This file in the future will reside in the JULES repository and will import | ||
| # jules-shared directly from there when the build system has been developed to | ||
| # allow this. | ||
| # |
There was a problem hiding this comment.
James Bruten (@james-bruten-mo) the change went awry.
Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
|
I think that file looks right now |
Maggie (maggiehendry)
left a comment
There was a problem hiding this comment.
Thanks James Bruten (@james-bruten-mo). Happy to approve 😄
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Changes look sensible
Sam Clarke-Green (t00sa)
left a comment
There was a problem hiding this comment.
Re-approving after merge and dependencies update
PR Summary
Sci/Tech Reviewer: Maggie (@maggiehendry)
Code Reviewer: Sam Clarke-Green (@t00sa)
This adds the
jules-lfricmetadata section, similar tojules-um, copied from lfric_apps. The metadata contained within has not been modified in the move, however old version directories and import version numbers have been changed to match Jules versions instead of lfric.This also adds the
jules-sea-seaicemetadata tojules-sharedagain copied from lfric but with version numbers updated.This allows the linked Apps PR to delete the
jules-lfricmetadata section and remove its copy ofjules-shared.Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
rose-meta/jules-sharedthen have you supplied a linked UM PR?Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Test Suite Results - jules - jules_meta/run2
Suite Information
Task Information
✅ succeeded tasks - 667
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Approvals
Please request all relevant approvals. See the CodeOwners.txt file for section
owners.
Technical
Scientific
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review