Skip to content

Add jules-lfric metadata - #110

Merged
Sam Clarke-Green (t00sa) merged 12 commits into
MetOffice:mainfrom
james-bruten-mo:copy_lfric_meta
May 29, 2026
Merged

Add jules-lfric metadata#110
Sam Clarke-Green (t00sa) merged 12 commits into
MetOffice:mainfrom
james-bruten-mo:copy_lfric_meta

Conversation

@james-bruten-mo

@james-bruten-mo James Bruten (james-bruten-mo) commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

Sci/Tech Reviewer: Maggie (@maggiehendry)
Code Reviewer: Sam Clarke-Green (@t00sa)

This adds the jules-lfric metadata section, similar to jules-um, copied from lfric_apps. The metadata contained within has not been modified in the move, however old version directories and import version numbers have been changed to match Jules versions instead of lfric.
This also adds the jules-sea-seaice metadata to jules-shared again copied from lfric but with version numbers updated.

This allows the linked Apps PR to delete the jules-lfric metadata section and remove its copy of jules-shared.

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings
  • If editing rose-meta/jules-shared then have you supplied a linked UM PR?

Testing

  • I have tested this change locally, using the JULES rose-stem suite
  • If shared files have been modified, I have run the UM and LFRic Apps rose
    stem suites
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

trac.log

Test Suite Results - jules - jules_meta/run2

Suite Information

Item Value
Suite Name jules_meta/run2
Suite User james.bruten
Workflow Start 2026-04-29T10:34:43
Groups Run all
Dependency Reference Main Like
jules james-bruten-mo/jules@copy_lfric_meta False
SimSys_Scripts MetOffice/SimSys_Scripts@2026.03.1 True

Task Information

✅ succeeded tasks - 667

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section
owners.

Technical

  • JULES Code Owner
  • OpenMP
  • River Routing
  • Rose Stem
  • Rose Metadata
  • Upgrade Macros

Scientific

  • Surface
  • Hydrology
  • Vegetation
  • Veg3 RED Demography
  • Biogechemistry
  • Biogenic fluxes
  • Fire
  • Lakes
  • Evaluation
  • Imogen

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Comment thread rose-meta/jules-lfric/HEAD/rose-meta.conf Outdated
Comment thread rose-meta/jules-lfric/vn7.9/rose-meta.conf
Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>

@maggiehendry Maggie (maggiehendry) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-bruten-mo

Copy link
Copy Markdown
Collaborator Author

https://github.com/MetOffice/jules/blob/main/.github/CODEOWNERS will need jules-lfric added.

Good point, that's done

# This file in the future will reside in the JULES repository and will import
# jules-shared directly from there when the build system has been developed to
# allow this.
#

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#
# This file is imported by jules-lsm in the LFRic apps repository.

This one also needs changing.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James Bruten (@james-bruten-mo) the change went awry.

@maggiehendry Maggie (maggiehendry) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vn8.1 needs changing like HEAD.

Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
@james-bruten-mo

Copy link
Copy Markdown
Collaborator Author

I've just updated the PR Template question reminding for the need of a linked PR when jules-shared is changed

@maggiehendry Maggie (maggiehendry) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would appear that I forgot to submit this one earlier.

Comment thread rose-meta/jules-lfric/vn8.1/rose-meta.conf Outdated
# This file in the future will reside in the JULES repository and will import
# jules-shared directly from there when the build system has been developed to
# allow this.
#

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James Bruten (@james-bruten-mo) the change went awry.

Co-authored-by: Maggie <145924708+maggiehendry@users.noreply.github.com>
@james-bruten-mo

Copy link
Copy Markdown
Collaborator Author

I think that file looks right now

@maggiehendry Maggie (maggiehendry) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks James Bruten (@james-bruten-mo). Happy to approve 😄

@t00sa Sam Clarke-Green (t00sa) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sensible

@t00sa Sam Clarke-Green (t00sa) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after merge and dependencies update

@t00sa
Sam Clarke-Green (t00sa) merged commit 5a234ea into MetOffice:main May 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants