Skip to content

Rename meshes for benefit of lfric2lfric - #551

Open
cjohnson-pi wants to merge 30 commits into
MetOffice:mainfrom
cjohnson-pi:rename_meshes
Open

Rename meshes for benefit of lfric2lfric#551
cjohnson-pi wants to merge 30 commits into
MetOffice:mainfrom
cjohnson-pi:rename_meshes

Conversation

@cjohnson-pi

@cjohnson-pi cjohnson-pi commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

PR Summary

Rename the mesh names (including prime_mesh_name, chain_mesh_tags, destination_mesh_name and source_mesh_name).

Sci/Tech Reviewer:
Code Reviewer: Ricky Wong (@mo-rickywong)

blocks #530

linked MetOffice/lfric_core#386

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Apps rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Run by first creating a lfric_apps test branch@vn3.2 (git switch vn3.2 --detach, git switch -c test_meshes)

Then applying to the associated lfric_core branch (from the components directory)
$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.2_t386 --core=.. --apps='/home/users/christine.johnson/git/lfric_apps

where git/lfric_apps is the the new test branch

Then merge the branch associated with this PR onto the lfric_apps test branch
git merge rename meshes
(being careful to resolve conflicts)

Then applying to the lfric_apps test branch
$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.2_t551

Test Suite Results - lfric_apps - rename_meshes/run2

Suite Information

Item Value
Suite Name rename_meshes/run2
Suite User christine.johnson
Workflow Start 2026-07-17T15:54:21
Groups Run suite_default
Dependency Reference Main Like
casim MetOffice/casim@2026.07.1 True
jules MetOffice/jules@2026.07.1 True
lfric_apps cjohnson-pi/lfric_apps@test_meshes False
lfric_core MetOffice/lfric_core@2026.07.1 True
moci MetOffice/moci@2026.07.1 True
SimSys_Scripts MetOffice/SimSys_Scripts@2026.07.1 True
socrates MetOffice/socrates@2026.07.1 True
socrates-spectral MetOffice/socrates-spectral@2026.07.1 True
ukca MetOffice/ukca@2026.07.1 True

Task Information

✅ succeeded tasks - 1210

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@cjohnson-pi cjohnson-pi self-assigned this Jun 11, 2026
@cjohnson-pi cjohnson-pi added the Linked Core This PR is linked to a MetOffice/lfric_core PR label Jun 11, 2026
@cjohnson-pi cjohnson-pi added this to the Autumn 2026 milestone Jun 11, 2026
@github-actions github-actions Bot added the cla-modified The CLA has been modified as part of this PR - added by GA label Jun 22, 2026
@cjohnson-pi cjohnson-pi added the macro This PR contains a metadata upgrade macro label Jun 23, 2026
@cjohnson-pi cjohnson-pi changed the title Rename meshes Rename meshes for benefit of lfric2lfric Jul 3, 2026
@github-actions github-actions Bot removed the cla-modified The CLA has been modified as part of this PR - added by GA label Jul 17, 2026

@davelee2804 David Lee (davelee2804) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks cjohnson-pi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Linked Core This PR is linked to a MetOffice/lfric_core PR macro This PR contains a metadata upgrade macro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants