Rename meshes for benefit of lfric2lfric - #551
Open
cjohnson-pi wants to merge 30 commits into
Open
Conversation
29 tasks
28 tasks
cjohnson-pi
marked this pull request as ready for review
July 20, 2026 08:51
David Lee (davelee2804)
approved these changes
Jul 20, 2026
David Lee (davelee2804)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me - thanks cjohnson-pi !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Rename the mesh names (including prime_mesh_name, chain_mesh_tags, destination_mesh_name and source_mesh_name).
Sci/Tech Reviewer:
Code Reviewer: Ricky Wong (@mo-rickywong)
blocks #530
linked MetOffice/lfric_core#386
Code Quality Checklist
Testing
trac.log
Run by first creating a lfric_apps test branch@vn3.2 (git switch vn3.2 --detach, git switch -c test_meshes)
Then applying to the associated
lfric_corebranch (from the components directory)$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.2_t386 --core=.. --apps='/home/users/christine.johnson/git/lfric_appswhere git/lfric_apps is the the new test branch
Then merge the branch associated with this PR onto the lfric_apps test branch
git merge rename meshes(being careful to resolve conflicts)
Then applying to the
lfric_appstest branch$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.2_t551
Test Suite Results - lfric_apps - rename_meshes/run2
Suite Information
Task Information
✅ succeeded tasks - 1210
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review