Including the changes to use F10.6 precision for domain_centre - #434
Open
Claudio Sanchez (mo-claudiosanchez) wants to merge 2 commits into
Open
Including the changes to use F10.6 precision for domain_centre#434Claudio Sanchez (mo-claudiosanchez) wants to merge 2 commits into
Claudio Sanchez (mo-claudiosanchez) wants to merge 2 commits into
Conversation
Claudio Sanchez (mo-claudiosanchez)
requested a review
from Ricky Wong (mo-rickywong)
as a code owner
July 23, 2026 09:23
Claudio Sanchez (mo-claudiosanchez)
requested a review
from a team
as a code owner
July 23, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Ricky Wong (@mo-rickywong)
Code Reviewer: mo-marqh
This PR is made to write the domain_centre variable in the mesh's "constructor_inputs" with higher truncation (from 2 to 6 decimals).
See issue #433
Code Quality Checklist
Testing
_The cylc-review of the rose stem testing is rose_stem_lfric_core/run1. All check_mesh_tools for LAMs fails as the branch outputs domain_centre with more zeroes. E.g.
trac.log
Suite Information
Task Information
❌ failed tasks - 60
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review