Skip to content

Including the changes to use F10.6 precision for domain_centre - #434

Open
Claudio Sanchez (mo-claudiosanchez) wants to merge 2 commits into
MetOffice:mainfrom
mo-claudiosanchez:mesh_domain_centre_10Fp6
Open

Including the changes to use F10.6 precision for domain_centre#434
Claudio Sanchez (mo-claudiosanchez) wants to merge 2 commits into
MetOffice:mainfrom
mo-claudiosanchez:mesh_domain_centre_10Fp6

Conversation

@mo-claudiosanchez

@mo-claudiosanchez Claudio Sanchez (mo-claudiosanchez) commented Jul 23, 2026

Copy link
Copy Markdown

PR Summary

Sci/Tech Reviewer: Ricky Wong (@mo-rickywong)
Code Reviewer: mo-marqh

This PR is made to write the domain_centre variable in the mesh's "constructor_inputs" with higher truncation (from 2 to 6 decimals).

See issue #433

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

_The cylc-review of the rose stem testing is rose_stem_lfric_core/run1. All check_mesh_tools for LAMs fails as the branch outputs domain_centre with more zeroes. E.g.

Result : /home/users/claudio.sanchez/cylc-run/rose_stem_lfric_core/run1/share/output/mesh_tools/mesh_tools_equator-band_azspice_gnu_fast-debug-64bit/mesh_equator-band.nc
KGO : /home/users/claudio.sanchez/cylc-run/rose_stem_lfric_core/run1/share/source/lfric_core/rose-stem/site/meto/kgos/mesh_tools/azspice/mesh_equator-band.gnu.kgo.nc

trac.log

Suite Information

Item Value
Suite Name rose_stem_lfric_core/run1
Suite User claudio.sanchez
Workflow Start 2026-07-23T09:03:13
Groups Run mesh_tools_developer
Dependency Reference Main Like
lfric_core mo-claudiosanchez/lfric_core@mesh_domain_centre_10Fp6 False
SimSys_Scripts MetOffice/SimSys_Scripts@cab3315 True

Task Information

❌ failed tasks - 60
Task State
check_mesh_tools_equator-band_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_equator-band_azspice_gnu_full-debug-64bit failed
check_mesh_tools_equator-band_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_equator_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_equator_azspice_gnu_full-debug-64bit failed
check_mesh_tools_equator_ex1a_cce_full-debug-64bit failed
check_mesh_tools_falklands_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_falklands_azspice_gnu_full-debug-64bit failed
check_mesh_tools_falklands_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_lam_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_lam_azspice_gnu_full-debug-64bit failed
check_mesh_tools_lam_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_london-model_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_london-model_azspice_gnu_full-debug-64bit failed
check_mesh_tools_london-model_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_nzlam4_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_nzlam4_azspice_gnu_full-debug-64bit failed
check_mesh_tools_nzlam4_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-bi-periodic_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-bi-periodic_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-bi-periodic_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-lbc_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-lbc_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-lbc_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-maps_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-maps_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-maps_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-non-periodic_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-non-periodic_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-non-periodic_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-op-lam_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-op-lam_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-op-lam_ex1a_cce_full-debug-64bit failed
check_mesh_tools_planar-stretch-centres_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-stretch-centres_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-stretch-centres_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-stretch-nodes_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-stretch-nodes_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-stretch-nodes_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-stretch-points_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-stretch-points_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-stretch-points_ex1a_gnu_fast-debug-64bit failed
check_mesh_tools_planar-trench-x_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-trench-x_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-trench-x_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_planar-trench-y_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_planar-trench-y_azspice_gnu_full-debug-64bit failed
check_mesh_tools_planar-trench-y_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_polar_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_polar_azspice_gnu_full-debug-64bit failed
check_mesh_tools_polar_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_uk_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_uk_azspice_gnu_full-debug-64bit failed
check_mesh_tools_uk_ex1a_cce_fast-debug-64bit failed
check_mesh_tools_var-poly-seuk_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_var-poly-seuk_azspice_gnu_full-debug-64bit failed
check_mesh_tools_var-poly-seuk_ex1a_gnu_fast-debug-64bit failed
check_mesh_tools_var-seuk_azspice_gnu_fast-debug-64bit failed
check_mesh_tools_var-seuk_azspice_gnu_full-debug-64bit failed
check_mesh_tools_var-seuk_ex1a_gnu_fast-debug-64bit failed
✅ succeeded tasks - 144
⌛ waiting tasks - 2
Task State
housekeep_azspice waiting
housekeep_ex1a waiting

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants