Load mesh limit open calls per rank - #446
Open
mo-marqh wants to merge 6 commits into
Open
Conversation
mo-marqh
requested review from
a team,
Andrew Coughtrie (andrewcoughtrie),
Mike Hobson (mike-hobson) and
Ricky Wong (mo-rickywong)
as code owners
August 10, 2026 11:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Andrew Coughtrie (@andrewcoughtrie)
Code Reviewer: Harry Shepherd (@harry-shepherd)
This changes delivers a targeted and limited scope refactor of the interaction between the
components/driver/source/driver_mesh_mod.f90mesh initialisation and theinfrastructure/source/io/ugrid_2d_modnetCDF interface.currently each read operation opens the file, reads a snippet of data, then closes the file.
this happens many times on each rank, e.g. 10 times for an
lfric_atmC896rank.this puts excessive load on parallel file systems and their metadata server provision.
combined with loading from a single mesh file across thousands of ranks, this load becomes unmanageable.
This change alters the internal interface to open the file once per rank, read all required information and close the file.
this reduces the number of file operations by a factor (e.g. factor 10 at
C896)this is a stand alone change, but it is intended to work with pre-partitioned meshes to manage load for large runs.
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - load_mesh_limit_open_calls_per_rank/run3
Suite Information
Task Information
✅ succeeded tasks - 433
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review