fix clicking on datasets#230
Open
ddelpiano wants to merge 5 commits intodevelopmentfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix dataset/query navigation when clicking dataset-related menu/history items, while also addressing a few UI/runtime issues encountered during navigation (template/individual alignment handling, Term Info layout tweaks, and StackViewer ref handling).
Changes:
- Reworked
RUN_QUERYmenu action parameter ordering and simplified the header query dispatch path. - Adjusted instance/template alignment logic in the URL updater middleware for individuals with missing visual metadata.
- Misc UI/runtime changes: suppress a noisy third‑party warning, refactor some Redux selectors, update TreeView icons API, and modernize a StackViewer ref.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/virtual-fly-brain/frontend/src/shared/header/index.jsx | Updates menu handler logic for showing components and running queries (parameter order + simplified query invocation). |
| applications/virtual-fly-brain/frontend/src/reducers/middleware/urlUpdaterMiddleware.js | Changes how individual/template alignment is determined when visual metadata is missing. |
| applications/virtual-fly-brain/frontend/src/main.jsx | Adds global suppression for a specific legacy React warning. |
| applications/virtual-fly-brain/frontend/src/components/TermInfo/TerminfoSlider.jsx | Switches to more granular selectors and tweaks image error handling/click behavior. |
| applications/virtual-fly-brain/frontend/src/components/TermInfo/GeneralInformation.jsx | Adds a missing React key and adjusts Grid sizing props in the Term Info layout. |
| applications/virtual-fly-brain/frontend/src/components/TermInfo.jsx | Updates some Typography wrappers and changes Grid sizing props; updates TreeView icon configuration. |
| applications/virtual-fly-brain/frontend/src/components/StackViewerComponent.jsx | Refactors away from string refs and adds guards around resize invocation. |
| applications/virtual-fly-brain/frontend/src/components/queryBuilder/Card.jsx | Improves tooltip text for markdown and makes id values clickable to load instances. |
| applications/virtual-fly-brain/frontend/src/components/configuration/VFBToolbar/vfbtoolbarMenuConfiguration.jsx | Updates menu parameter typing, submenu actions, history injector structure, and dataset query parameters. |
| applications/virtual-fly-brain/frontend/src/components/CameraControls.jsx | Wraps component with forwardRef and sets an explicit displayName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1045
to
1048
| <Grid container columnSpacing={2}> | ||
| {!showMetadataOnly && <Grid item xs={12} sm={4} md={5} lg={5}> | ||
| {!showMetadataOnly && <Grid size={{ xs: 12, sm: 4, md: 5, lg: 5 }}> | ||
| <Box | ||
| sx={{ |
Comment on lines
+240
to
+244
| // If Images is empty, the individual has no visuals and can be loaded by any template | ||
| if (Object.keys(action.payload?.Images || {}).length === 0) { | ||
| next(action); | ||
| updateUrlWithInstancesAndSelectedId(action.payload.Id, store); | ||
| return; |
Comment on lines
+5
to
+10
| // Suppress legacy childContextTypes warning from griddle-react/recompose (third-party, no fix available) | ||
| const _origConsoleError = console.error; | ||
| console.error = (...args) => { | ||
| if (typeof args[0] === 'string' && args[0].includes('childContextTypes')) return; | ||
| _origConsoleError(...args); | ||
| }; |
Comment on lines
1071
to
+1075
| xs: 2, | ||
| sm: 0, | ||
| }, | ||
| width: showMetadataOnly ? '100%' : 'initial' | ||
| }} item xs={12} sm={showMetadataOnly ? 12 : 8} md={showMetadataOnly ? 12 : 7} lg={showMetadataOnly ? 12 : 7}> | ||
| }} size={{ xs: 12, sm: showMetadataOnly ? 12 : 8, md: showMetadataOnly ? 12 : 7, lg: showMetadataOnly ? 12 : 7 }}> |
Comment on lines
+137
to
141
| const type = action.parameters[0]; | ||
| const short_form = action.parameters[1]; | ||
| getQueries(short_form, type); | ||
| setBottomNav(bottomNavQuery); | ||
| break; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.