Skip to content

Create eip155:44273 - #1942

Closed
ammar4243 wants to merge 3 commits into
MetaMask:masterfrom
Bitbrick-Technology-Pvt-LTD:master
Closed

Create eip155:44273#1942
ammar4243 wants to merge 3 commits into
MetaMask:masterfrom
Bitbrick-Technology-Pvt-LTD:master

Conversation

@ammar4243

@ammar4243 ammar4243 commented Sep 3, 2026

Copy link
Copy Markdown

Add Logo Avaride Token
<img width="512 height="512" alt="AVAR" src="https://github.com/user-attachments/assets/e9e81c2e-de10-445c-9158-1738ae2952bd" />


Note

Low Risk
Static icon and metadata only; the main caveat is the 44273 metadata may reference a logo path that this PR does not add.

Overview
Adds Avaride (AVAR, 9 decimals) as an ERC-20 asset in the token assets repo: a new 500×500 SVG logo and matching JSON metadata for contract 0x77199eaa4eabc6CB0ADf5c26fF1dC12867583cCA on eip155:56 (BSC).

Also introduces metadata/eip155:44273 with the same token fields for chain 44273, pointing its logo at ./icons/eip155:44273/erc20:0x77199eaa...svg. That 44273 icon file is not included in this diff (only the eip155:56 icon path is added), so reviewers may want to confirm the intended layout matches other chains (metadata/eip155:<id>/erc20:<addr>.json).

Reviewed by Cursor Bugbot for commit 88d5a37. Bugbot is set up for automated code reviews on this repo. Configure here.

Add Logo Avaride Token
@ammar4243
ammar4243 requested review from a team and MRabenda as code owners September 3, 2026 14:11
Comment thread metadata/eip155:44273
"decimals": 9,
"erc20": true,
"logo": "./icons/eip155:44273/erc20:0x77199eaa4eabc6CB0ADf5c26fF1dC12867583cCA.svg"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata file placed at wrong path, missing directory structure

High Severity

The file is placed directly at metadata/eip155:44273 as a flat file, but the repository convention requires it to be inside a chain directory as a .json file — e.g., metadata/eip155:44273/erc20:0x77199eaa4eabc6CB0ADf5c26fF1dC12867583cCA.json. Every other chain entry in the metadata/ folder is a directory containing individual token .json files. The buildindex.js script will index this with the key eip155:44273 instead of the expected eip155:44273/erc20:0x77199eaa4eabc6CB0ADf5c26fF1dC12867583cCA, causing the token to not be found correctly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e53f65a. Configure here.

Comment thread metadata/eip155:44273
Adding AVAR Token Logo

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 88d5a37. Configure here.

<path d="M0 0 C0.99 0 1.98 0 3 0 C1.63016497 3.16115776 1.0109362 3.9927092 -2 6 C-1.125 1.125 -1.125 1.125 0 0 Z " fill="#19A3CB" transform="translate(168,116)"/>
<path d="M0 0 C1.7074998 1.28062485 3.37373596 2.61767557 5 4 C5 4.66 5 5.32 5 6 C3.68 5.67 2.36 5.34 1 5 C0.67 3.35 0.34 1.7 0 0 Z " fill="#092E77" transform="translate(342,112)"/>
<path d="M0 0 C0.33 0.99 0.66 1.98 1 3 C-0.32 4.32 -1.64 5.64 -3 7 C-3.33 6.01 -3.66 5.02 -4 4 C-2.68 2.68 -1.36 1.36 0 0 Z " fill="#0CBAEF" transform="translate(178,91)"/>
</svg>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG filename missing colon breaks logo path resolution

High Severity

The SVG file is named erc200x77199eaa... but it needs to be erc20:0x77199eaa... (with a colon between erc20 and 0x). Every other file in the eip155:56 directory uses the erc20:0x convention, and the existing JSON metadata file for this token references ./icons/eip155:56/erc20:0x77199eaa4eabc6CB0ADf5c26fF1dC12867583cCA.svg. The missing colon means the logo won't be resolved by anything looking up this token's icon.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 88d5a37. Configure here.

@ammar4243 ammar4243 closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant