chore: shorten tokenlist CDN cache and invalidate it after upload - #1948
Open
hurricanenara wants to merge 1 commit into
Open
chore: shorten tokenlist CDN cache and invalidate it after upload#1948hurricanenara wants to merge 1 commit into
hurricanenara wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
CI-only change to cache headers and an optional CloudFront invalidation; no application auth or data-path changes, though enabling the step requires correct IAM and repo vars to avoid failed runs.
Overview
Updates the Generate Uniswap Token List workflow so fresh token merges reach downstream consumers (e.g. tokens API polling every ~20 minutes) sooner.
The S3 upload now sets
Cache-Control: max-age=300(was 3600), shortening how long the CDN may serve a stale copy without an explicit purge.A new Invalidate CDN cache step runs
aws cloudfront create-invalidationfor/${{ env.S3_PATH }}when the repo variableSTATIC_CF_DISTRIBUTION_IDis set; otherwise it is skipped until that variable andcloudfront:CreateInvalidationon the S3 role are configured.Reviewed by Cursor Bugbot for commit 0724336. Bugbot is set up for automated code reviews on this repo. Configure here.