Add sglang sglang check env topology timeout - #9
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a timeout constant (CHECK_ENV_COMMAND_TIMEOUT = 10) and applies it to the subprocess.run calls within the get_topology methods across various environment classes (GPUEnv, HIPEnv, NPUEnv, and MUSAEnv) in python/sglang/check_env.py. It also adds a new unit test file test/registered/unit/test_check_env.py to verify that the timeout is correctly passed to these subprocess calls. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Validation
Review notes