MRB-720 Add option to read ICON baselines directly from GRIBs#153
Conversation
|
@dnerini thanks heaps for this. here's my two cents:
|
jonasbhend
left a comment
There was a problem hiding this comment.
Hi @dnerini
One final thought. I would expect that there is quite some redundancy between load_fct_data_from_grib and load_baseline_from_grib. In essence the only thing that should be necessary is to generalize the way grib files are found, then one could use load_fct_data_from_grib for both ML forecasts and baseline gribs. I would much prefer to do it that way to facilitate future developments and reduce redundancy. Or is there a blocker I am overlooking?
And consequently remove legacy cosmo configs that are no longer supported
|
note that commit 8619fea removes all legacy cosmo configs |
|
@dnerini very nice, I like it a lot! I suggest to tackle harmonization of data_input across experiments and showcases in a separate PR to benefit from the work being done here. |
|
Need to fix some tests, but after that I would maybe suggest to merge and leave the TODOs to future PRs |
fine with me. Just out of curiosity, does the current implementation already support reading ensembles? |
not yet, no, let's add that in a separate PR |
jonasbhend
left a comment
There was a problem hiding this comment.
Looking good. I didn't have time to run the example notebook. Let me know if I should give it a spin.
It's really hard to do a proper comparison, especially when submitting jobs on Balfrin, because scheduling is not optimal and your jobs can randomly contend resources with others. Did you try running a quick comparison on the login node? |
This PR adds the option to read ICON-CH1/2-EPS surface GRIB files directly from the operational archive. It also removes the legacy zarr reader for baselines and consequently all cosmo-based config files.
Results
Quick test shows no difference in results between the existing zarr and the new grib readers

Performance-wise, it doesn't seem to make a big difference, which I find a bit odd, so I'll need to have a closer look.
Open questions
should we deprecate the baselines zarr instead?Done in 8619feashould we use switch to earthkit v1?Out of scopeshould we deprecate the dependency on meteodata-lab?Out of scope, already part of MRB-665 Support for global models and remove meteodata-lab #90Follow-up PRs