Extract ICON baseline ensmean#167
Open
dnerini wants to merge 31 commits into
Open
Conversation
Resolve conflicts: - inference_extract_requirements.py: keep branch's newer eccodes pins (eccodes>=2.44.0,<2.48.0 / eccodes-cosmo-resources-python==2.44.0.1). - plot_forecast_frame.py / plot_meteogram.py: main refactored these from marimo notebooks (.mo.py) into plain scripts with new CLI (regions_json/ stations/outdir). Took main's structure and re-applied the branch's earthkit-v1 data-model renames: step (not lead_time), valid_time (not time) for forecasts/baselines, latitude/longitude (not lat/lon) station coords, plus the grib-glob workaround for forecast frames.
Co-authored-by: Jonas Bhend <jonasbhend@users.noreply.github.com>
Co-authored-by: Jonas Bhend <jonasbhend@users.noreply.github.com>
jonasbhend
reviewed
Jun 1, 2026
Contributor
jonasbhend
left a comment
jonasbhend
left a comment
There was a problem hiding this comment.
Cool. Looks straightforward to me. I will try now to see if it works as expected.
jonasbhend
approved these changes
Jun 4, 2026
Contributor
jonasbhend
left a comment
jonasbhend
left a comment
There was a problem hiding this comment.
Very nice. Very cool addition indeed.
Using the median is a bit more tricky though, because we cannot aggregate on it. I.e. the 6hourly precipitation coming from the hourly median that is read through this PR will have a significant negative bias. So as soon as we make aggregation explicity, we should make sure that we read the corresponding median files (e.g. ..._median06h) for aggregated parameters.
Maybe best to add a warning / comment in the code so we don't forget.
Member
Author
|
Thanks for the review! Let's wait for #162 before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.