Skip to content

Fix: Quiver module#6404

Open
weoworwfjjgeagerg wants to merge 1 commit into
MeteorDevelopment:masterfrom
weoworwfjjgeagerg:master
Open

Fix: Quiver module#6404
weoworwfjjgeagerg wants to merge 1 commit into
MeteorDevelopment:masterfrom
weoworwfjjgeagerg:master

Conversation

@weoworwfjjgeagerg
Copy link
Copy Markdown

Type of change

  • Bug fix
  • New feature

Description

Fixes various reported issues.

Related issues

#6343

How Has This Been Tested?

Singleplayer using Meteor Client and Sodium. All changes are working fine.

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

- Add check to bypass armor slots
- Use item.get(DataComponents.POTION_CONTENTS) instead of item.getItem().components() to get potion effects. FIxes mayor issue of status effects not properly detected.
- Switch from meteor$isHasCollision() to getCollisionShape() to return real shape for any block state. Fixes issues with slabs and fences.
- Change starting point to getEyeY() (actual eyes position) and checks 3 blocks upward to ensure arrow dont hit any block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant