Nametag module and item list setting screen imporvements#6406
Open
cqb13 wants to merge 5 commits into
Open
Conversation
- Added ability to control which items nametags are rendered on instead of just all or no items - Made item list setting have categories (Blocks, Tools, Weapons, Food, etc...) sorta like how the entity one has categories
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
How Has This Been Tested?
If a list setting is opened in the main menu before a world is joined, the categories will not be computed correctly. I'm pretty sure this is because the data components have not been loaded yet or something like that. After the player has joined a world, the categories will be fine even in the main menu. (In current meteor, nothing is shown, as seen below, so I think this is a setup, not sure if there is a good solution to this)
Checklist: