viewer: fix parse-mode error format mismatch (Fixes #5103)#5104
Closed
azazar wants to merge 1 commit into
Closed
Conversation
github-actions
Bot
added
needs triage
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the viewer’s “parse mode” error path by correcting a printf-style format string to match how errors are rendered via file_error_message().
Changes:
- Adjusted the parse-mode “Cannot open…” error format string to use a single
%splaceholder, matching the single filename argument provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
LLM messed up commit metadata, I'll resubmit it. |
Member
|
Superseded by #5105. |
zyv
added
area: mcview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a segfault in viewer parse-mode error handling.
Root cause: format string expected two %s arguments, but only one was passed.
Fix: in mcviewer.c, change the parse-mode error format to a single %s so it matches file_error_message() usage.
Regression introduced by d69da19 (mcviewer: use file_error_message()).
Fixes #5103.