fix(app): remove duplicate ProgressModule registration in AppModule - #670
Open
Ummi-001 wants to merge 1 commit into
Open
fix(app): remove duplicate ProgressModule registration in AppModule#670Ummi-001 wants to merge 1 commit into
Ummi-001 wants to merge 1 commit into
Conversation
ProgressModule was listed twice in AppModule.imports (once among the feature modules and again after BlockchainModule). NestJS deduplicates modules internally so this was not fatal, but it misled readers auditing module wiring and wasted reviewer cycles. - Keep the single registration next to the other feature modules - Alphabetize the static imports array so future duplicates stand out; forRoot/registerAsync configuration blocks keep their logical order
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #658
Summary
backend/src/app.module.tslistedProgressModuletwice in itsimportsarray — once among the feature modules and again afterBlockchainModule. NestJS deduplicates modules internally, so this was not fatal at runtime, but it was misleading for anyone auditing the module wiring (e.g. tracing the progress-to-analytics event flow) and kept getting flagged in review.Changes
ProgressModuleentry; it now appears exactly once inAppModule.importsConfigModule.forRoot,EventEmitterModule.forRoot,ScheduleModule.forRoot,TypeOrmModule.forRootAsync) keep their position first, and the dynamicJwtAuthModule.registerAsync(...)middleware registration stays last — NestJS resolves modules as a dependency graph, so reordering the plain imports has no runtime effectVerification
grep -n ProgressModule backend/src/app.module.ts→ one import + one registrationnpm --workspace backend run buildpasses locally (tsc, no errors)