feat: implement comprehensive error handling framework - #427
Open
cyber-excel10 wants to merge 1 commit into
Open
feat: implement comprehensive error handling framework#427cyber-excel10 wants to merge 1 commit into
cyber-excel10 wants to merge 1 commit into
Conversation
- Add error hierarchy with BaseException, DomainException, InfrastructureException - Create 25+ custom exception classes for quest service domain - Implement standardized error codes system with 50+ error codes - Add circuit breaker pattern for external service fault tolerance - Implement retry logic with exponential backoff and jitter - Create error recovery strategies (RETRY, FALLBACK, CIRCUIT_BREAKER, etc.) - Enhance global exception filter with proper logging and Sentry integration - Add client-friendly error responses with retry guidance - Create comprehensive test suite - Update validation pipe to use new framework Resolves MindFlowInteractive#400
|
@cyber-excel10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #400
Description
Implements a global error handling framework for
quest-servicewith standardized error codes, custom exceptions, circuit breaker fault tolerance, exponential backoff retries, and unified response formatting.Key Changes
BaseException,DomainException, andInfrastructureExceptionroots to avoid collisions with standard NestJS exceptions.AppNotFoundException,AuthenticationException, etc.).HttpExceptionFilterand updatedValidationPipeto seamlessly process custom and legacy exceptions.Verification & Compatibility
npx tsc --noEmit.Test Output