fix: Duplicate source IDs and malformed source filenames [SOURCES] - #1578
Open
peatoe wants to merge 1 commit into
Open
fix: Duplicate source IDs and malformed source filenames [SOURCES]#1578peatoe wants to merge 1 commit into
peatoe wants to merge 1 commit into
Conversation
Rename several GTFS source files and update internal IDs for consistency. Updated realtime files and their mdb_source_id values: es-basque-country-bilbobus (2698 → 3409), it-cotral-busone (3388 → 3410), us-maine-south-portland (2647 → 3408). Also renamed two schedule files to use .json extension: fr-normandie-hobus-gtfs-2685.zip → fr-normandie-hobus-gtfs-2685.json and us-virginia-roanoke-cortran-flex-gtfs-2435 → us-virginia-roanoke-cortran-flex-gtfs-2435.json. These changes normalize filenames/extensions and align source metadata with updated mdb entries.
peatoe
marked this pull request as ready for review
July 30, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the duplicate and stray ID issues found while preparing #1572, as discussed with @emmambd in #1572 (comment). Five files, renames plus three ID changes, no test changes (pausing on the test itself per that comment).
Renamed, IDs unchanged
us-virginia-roanoke-cortran-flex-gtfs-2435to...2435.json(extension was missing)fr-normandie-hobus-gtfs-2685.zipto...2685.json(JSON content, wrong extension)Renumbered: duplicate IDs inside the realtime catalog
The catalog is keyed on
mdb_source_id, so one file silently hides the other. Before this PR, 979 realtime files produced 977 visible sources.Visible feeds keep their current IDs. Nothing references the renumbered entries (no redirects, no
static_reference), and they were hidden until now, so nothing downstream can be using them.Left alone: mdb-3204
Shared by the Cathleen Stone ferry (schedule) and El Paso vp (realtime). Both are published and visible in their own catalogs, so renumbering would change a public ID. Your call, happy to include it here or in a follow-up.