fix(quickstart): pin current build + force protocol 27 via SSOT#131
Merged
Conversation
The quickstart v640+ images (current :latest = v642-b1163.1) ship
stellar-core v27 but default the --local network to protocol 25, which
fails every contract upload with HostError(Context, InternalError).
v639 (core v26) worked, hence the earlier :v639-b1103.1-latest pin.
Fix forward instead of freezing on v639: move every quickstart usage
onto the validated v642-b1163.1-latest build and force --protocol-version
27 (matches the bundled core and live testnet). Verified the full deploy
flow clean on the current image with the flag.
Single source of truth: stellar-pin.env holds the image tag + protocol.
Read by the docker-compose.*.yml files, e2e/lifecycle/multi-asset compose
(via ${STELLAR_QUICKSTART_IMAGE}/${STELLAR_PROTOCOL_VERSION}), test.sh,
infra-up.sh, down.sh, lifecycle/provider.ts, and the reusable CI workflows
(load step -> $GITHUB_ENV) so they cannot diverge. --protocol-version is
marked a workaround at each site, to drop when a fixed image ships.
Add quickstart-drift.yml: weekly + dispatch alarm that compares live
testnet protocol to the pin and nags Discord (secrets.DISCORD_WEBHOOK_URL,
dormant until set) on every run while testnet is ahead.
e2e.yml runs docker compose inline on PRs (it does not call the reusable),
so it also needs the SSOT loaded into $GITHUB_ENV before compose can
interpolate ${STELLAR_QUICKSTART_IMAGE}/${STELLAR_PROTOCOL_VERSION}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
stellar/quickstartv640+ images (current:latest=v642-b1163.1) ship stellar-core v27 but default the--localnetwork to protocol 25, which fails every contract upload withHostError(Context, InternalError).v639(core v26) worked, hence the earlier:v639-b1103.1-latestpin.Root cause is the image's protocol-default misfire, not a client/toolchain problem. Forcing the protocol to match the core makes uploads/deploys work — verified: the full deploy flow (and council-console's
deploy_test) is clean on the current image with--protocol-version 27, with both old and newstellar-cli. So we fix forward onto the current build instead of freezing on v639.Changes
stellar-pin.env(new) — single source of truth: the pinned image tag (v642-b1163.1-latest, never floating:latest) +STELLAR_PROTOCOL_VERSION=27.e2e/,lifecycle/,multi-asset/) — interpolate${STELLAR_QUICKSTART_IMAGE}and append--protocol-version ${STELLAR_PROTOCOL_VERSION}.test.sh,infra-up.sh,down.sh— source the SSOT;infra-up.sh'sstellar container startnow uses the pinned tag +--protocol-version.lifecycle/provider.ts— reads the SSOT and passes the image +--protocol-version.$GITHUB_ENVbeforedocker compose..github/workflows/quickstart-drift.yml(new) — weekly +workflow_dispatchalarm: compares live testnet protocol (Horizon, RPC fallback) to the pin and posts to Discord (secrets.DISCORD_WEBHOOK_URL, read only from the secret) on every run while testnet is ahead. Wired but dormant until the secret is set out-of-band; minimalcontents: readpermission.--protocol-versionis marked a workaround at each site, to remove when a fixed image ships.Validation
--local --limits unlimited --protocol-version 27; network comes up at protocol 27.v642-b1163.1-latest --protocol-version 27(upload + instantiate + add/remove provider).deno fmt --check+deno lintgreen in all CI matrix dirs (deno 2.9.1); shellbash -nclean; all workflow YAML parses.No version bump: local-dev has no version field / release automation.