feat(web): hide ACP-created sessions and workspaces from the sidebar #1908
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@moonshot-ai/acp-adapter": patch | ||
| "@moonshot-ai/kimi-web": patch | ||
| --- | ||
|
|
||
| Tag ACP-created sessions with `source: 'acp'` (plus the client's `clientInfo.name`) in their persisted custom metadata, and add a kimi-web setting (on by default) that hides ACP-created sessions and ACP-only workspaces from the sidebar and archived lists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // apps/kimi-web/src/lib/acpSessions.test.ts | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import type { AppSession } from '../api/types'; | ||
| import { acpOnlyWorkspaceRoots, isAcpSession } from './acpSessions'; | ||
| import { workspaceRootKey } from './rootKey'; | ||
|
|
||
| function makeSession(overrides: Partial<AppSession>): AppSession { | ||
| return { | ||
| id: 'session_1', | ||
| title: 't', | ||
| createdAt: '2026-01-01T00:00:00Z', | ||
| updatedAt: '2026-01-01T00:00:00Z', | ||
| busy: false, | ||
| archived: false, | ||
| cwd: '/repo', | ||
| model: 'kimi', | ||
| usage: { | ||
| inputTokens: 0, | ||
| outputTokens: 0, | ||
| cacheReadTokens: 0, | ||
| cacheCreationTokens: 0, | ||
| totalCostUsd: 0, | ||
| contextTokens: 0, | ||
| contextLimit: 0, | ||
| turnCount: 0, | ||
| }, | ||
| messageCount: 0, | ||
| lastSeq: 0, | ||
| ...overrides, | ||
| }; | ||
| } | ||
|
|
||
| describe('isAcpSession', () => { | ||
| it('matches exactly the acp source tag', () => { | ||
| expect(isAcpSession(makeSession({ source: 'acp' }))).toBe(true); | ||
| expect(isAcpSession(makeSession({ source: 'vscode' }))).toBe(false); | ||
| expect(isAcpSession(makeSession({}))).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| describe('acpOnlyWorkspaceRoots', () => { | ||
| it('reports roots whose sessions are all ACP-created', () => { | ||
| const roots = acpOnlyWorkspaceRoots([ | ||
| makeSession({ id: 'a', cwd: '/agent/s_1', source: 'acp' }), | ||
| makeSession({ id: 'b', cwd: '/agent/s_1', source: 'acp' }), | ||
| makeSession({ id: 'c', cwd: '/repo', source: undefined }), | ||
| ]); | ||
| expect(roots).toEqual([workspaceRootKey('/agent/s_1')]); | ||
| }); | ||
|
|
||
| it('hides nothing when a workspace has any non-ACP session', () => { | ||
| const roots = acpOnlyWorkspaceRoots([ | ||
| makeSession({ id: 'a', cwd: '/mixed', source: 'acp' }), | ||
| makeSession({ id: 'b', cwd: '/mixed' }), | ||
| ]); | ||
| expect(roots).toEqual([]); | ||
| }); | ||
|
|
||
| it('never reports a root with no ACP session (no vacuous truth on empty/ACP-free sets)', () => { | ||
| expect(acpOnlyWorkspaceRoots([])).toEqual([]); | ||
| expect(acpOnlyWorkspaceRoots([makeSession({ id: 'a', cwd: '/repo' })])).toEqual([]); | ||
| }); | ||
|
|
||
| it('skips sessions without a cwd', () => { | ||
| const roots = acpOnlyWorkspaceRoots([makeSession({ id: 'a', cwd: '', source: 'acp' })]); | ||
| expect(roots).toEqual([]); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On mobile,
App.vueopensMobileSettingsSheetinstead of the desktopSettingsDialog, and this newly added filter is controlled byclient.hideAcpSessions, which defaults to true. Because the mobile sheet has no corresponding toggle/event, mobile users cannot turn the filter off to find or restore archived ACP sessions, or reveal hidden ACP workspaces, from the mobile UI; add the same setting row here or pass through the existing setter.Useful? React with 👍 / 👎.