feat: show local reset time alongside countdown in /usage hints#1914
Open
huanglizhuo wants to merge 2 commits into
Open
feat: show local reset time alongside countdown in /usage hints#1914huanglizhuo wants to merge 2 commits into
huanglizhuo wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: b7cfc42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
huanglizhuo
changed the title
huanglizhuo
marked this pull request as ready for review
July 19, 2026 11:13
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fee69b6b79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
resetHintFrom built the epoch from Date.now() and resetHintForEpoch read the clock again before flooring the difference, so any elapsed millisecond dropped a full second: reset_in 120 rendered "1m" and reset_in 1 rendered "reset". Thread a single reference time through both, and use it for the local-clock date comparison as well. Pin the boundary tests to a frozen clock so they assert exact strings instead of skipping on midnight/year edges, and cover the double-read regression with a clock that ticks between calls. Also correct the changeset to name the package that actually changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #1915
Problem
See linked issue.
What changed
resets in 2h 30m (at 14:30). This applies uniformly to rows backed by an absolute timestamp (reset_at/resetAt/...) and to rows backed by relative seconds (reset_in/ttl), where the absolute moment is derived from the fetch time.Dategetters, with date context graded by distance so a bare clock time is never ambiguous:HH:MMwithin the same day,MM-DD HH:MMwithin the same year,YYYY-MM-DD HH:MMacross years.reset, and unparseable timestamps still fall back toresets at <raw value>.Before vs After
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.