Security: Stored XSS via unsanitized rich HTML rendering#172
Open
tuanaiseo wants to merge 2 commits intoMrXujiang:masterfrom
Open
Security: Stored XSS via unsanitized rich HTML rendering#172tuanaiseo wants to merge 2 commits intoMrXujiang:masterfrom
tuanaiseo wants to merge 2 commits intoMrXujiang:masterfrom
Conversation
User-controlled `content` is rendered with `dangerouslySetInnerHTML` without sanitization. An attacker can inject scripts/event handlers (for example via stored page content) and execute arbitrary JavaScript in visitors' browsers. Affected files: index.tsx, index.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
User-controlled `content` is rendered with `dangerouslySetInnerHTML` without sanitization. An attacker can inject scripts/event handlers (for example via stored page content) and execute arbitrary JavaScript in visitors' browsers. Affected files: index.tsx, index.tsx Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
User-controlled
contentis rendered withdangerouslySetInnerHTMLwithout sanitization. An attacker can inject scripts/event handlers (for example via stored page content) and execute arbitrary JavaScript in visitors' browsers.Severity:
highFile:
src/materials/base/RichText/index.tsxSolution
Sanitize HTML before rendering (e.g., DOMPurify with a strict allowlist) and strip dangerous tags/attributes (
script,on*,javascript:URLs). Prefer rendering structured rich-text data instead of raw HTML where possible.Changes
src/materials/base/RichText/index.tsx(modified)src/materials/shop/ZhuanLan/index.tsx(modified)Testing