Cleanup CFO loopback behavior#314
Open
rrivera747 wants to merge 4 commits into
Open
Conversation
michaelmackenzie
approved these changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines CFO/DTC loopback-related FE macros to make loopback behavior and outputs clearer during manual setup and automated testing, including adding Plotly histogram output for delay measurements.
Changes:
- Updated the DTC “Loopback Manual Setup” macro interface to better communicate the default passthrough behavior and to return a formatted control-register result.
- Forced the CFO loopback test “exponent” behavior to a fixed value (0) and removed it from the user-facing argument list.
- Added Plotly histogram generation for loopback delay measurements in both the DTC emulator loopback tests and the CFO loopback test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc | Updates loopback manual-setup macro arguments/outputs and adds Plotly histogram output for emulator loopback delay measurements. |
| otsdaq-mu2e/FEInterfaces/CFOFrontEndInterfaceImpl.cc | Fixes loopback test parameterization (fixed exponent), adds Plotly histogram output, and adds a user-facing message for failed measurements (currently with a logic issue). |
Comment on lines
+974
to
+977
| if(ostr.str().empty()) | ||
| ostr << "No loopback measurements were successful. Check the link status of " | ||
| "targeted links." | ||
| << std::endl; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.