Viewer state refactor#1375
Merged
Merged
Conversation
…rted building out a test harness before we move further.
|
Preview removed. |
eyeseast
marked this pull request as ready for review
July 16, 2026 18:31
eyeseast
requested review from
allanlasser,
duckduckgrayduck and
mitchelljkotler
July 16, 2026 18:32
Collaborator
Author
|
There are a bunch of storybook snapshots that look like they're not loading correctly. As far as I can tell, these are snapshot errors, and the actual storybook is working fine. I am going to upgrade storybook in a separate PR to hopefully fix some of this. |
mitchelljkotler
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidating all viewer state into one class, in
src/lib/state/viewer.svelte.ts, plus an extensive test suite for safety.Everything in the viewer should just work like it did before. This is entirely internal, but it opens up later fixes for viewer work.