Storybook upgrade#1377
Merged
Merged
Conversation
|
Preview removed. |
Target SB10, not SB9: @storybook/sveltekit@9 does NOT mock $app/state
(only $app/{forms,navigation,stores}); the $app/state mock shipped in
SB10 (static/app-state-mock.svelte.js). Since the app now reads `page`
exclusively from $app/state, SB10 is required to inject a URL into
URL-dependent stories.
- Core → 10.5.0 (storybook, sveltekit, svelte, addon-docs, addon-links);
addon-svelte-csf → ^5.1.2; msw-storybook-addon → ^2.0.7.
- Remove folded-in addon-essentials/addon-interactions, dead
@storybook/test + @storybook/addon-actions, and auto-added addon-mcp.
- Codemods: action → storybook/actions, INITIAL_VIEWPORTS →
storybook/viewport, renderer types @storybook/svelte →
@storybook/sveltekit, drop docs.autodocs: "tag".
- Remove storybook-addon-cookie (incompatible with SB9+; imports removed
SB8 packages). Replace with document.cookie = "csrftoken=mockToken" in
preview.ts (getCsrfToken reads csrftoken from document.cookie).
- $app/state verified: PDFPage "search results" page.url reflects the
injected ?q= URL. Remove "inert until upgrade" comments.
Verified: build-storybook ✓, svelte-check 0 errors, 990 unit tests pass,
all 545 stories render headless.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
eyeseast
marked this pull request as ready for review
July 20, 2026 13:38
…o 1376-storybook-9
allanlasser
approved these changes
Jul 22, 2026
Member
|
Excellent cleanup job here—no changed tests with the upgrade is impressive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1376