add BIB utils#15
Merged
Merged
Conversation
Run the repository pre-commit hooks (clang-format, license headers, trailing-whitespace) over all files so the pre-commit CI check passes: - clang-format: reformat existing sources to the repo .clang-format style - licenseheaders: add the Apache-2.0 header to files that were missing it - trailing-whitespace: strip trailing whitespace - add the markdown license header to k4Reco/BIBUtils/README.md These are formatting-only changes; no logic was modified, and the k4RecoPlugins module still builds cleanly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Key4hep CI builds with -Werror; fix the warnings it flagged in the existing sources (none are in the new BIBUtils code): - -Wsign-compare: use std::size_t for loop counters compared against container .size() in FastJetAlg, RealisticCaloDigi, RealisticCaloReco and OverlayTimingRandomMix; cast to int only where set_user_index needs it - -Wunused-function: mark the anonymous-namespace operator<< for EClusterMode [[maybe_unused]] (used only in some translation units) - -Wunused-variable: mark the unused loop variable in OverlayTimingRandomMix [[maybe_unused]] Verified with a -Werror build (gcc 13.3.0) that our sources compile warning-free. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few BIB-rejection-related algorithms implemented in Gaudi-native form