WIP - IGNORE - follow-up/cleanup for feature/cagen-v1#764
Draft
climbfuji wants to merge 4 commits into
Draft
Conversation
…t doesn't hurt is today w.r.t. escaping periods in decimals in capgen/metadata/parse_tools/fortran_conditional.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets the feature/capgen-v1 branch with follow-up and cleanup changes from manual code reviews. This branch is being used by the CAM-SIMA feature branches that replace the original capgen v0 with the new capgen v1.
feature/capgen-v1.capgen/metadata/parse_tools/parse_source.py. Some of the removed features were (ab)used by CAM-SIMA and are now in the updated capgen compatibility layer in the CAM-SIMA feature branch.capgen/metadata/parse_tools/parse_log.py. Requires a tiny change in the CAM-SIMA compatibility layer (now in the (CAM-SIMA feature branch).capgen/metadata/parse_tools/fortran_conditional.py.User interface changes?: No (so far - the goal of these clean up changes is no API changes).
Fixes: [Github issue #s] MISSING
Testing: MISSING
test removed:
unit tests:
system tests:
manual testing: