Introduce AddPerfdata to PartialResult to ensure concurrency-safety#162
Merged
Conversation
RincewindsHat
approved these changes
Jun 25, 2026
RincewindsHat
left a comment
RincewindsHat
left a comment
Member
There was a problem hiding this comment.
make sense.
should all the other attributes of PartialResult receive the same treatment?
martialblog
commented
Jun 29, 2026
martialblog
commented
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the code with @christoph2497 I noticed the PartialResults Perfdatalist was exposed as a public attribute, with our new design that is not concurrency-safe.
To fix it I introduced an AddPerfdata on the PartialResults.