Validate JSONFeed version and rework feed detection - #86
Merged
Conversation
So that we can differentiate between detection errors and data errors that we can then show to the user
martialblog
force-pushed
the
jsonfeed-version
branch
from
July 30, 2026 09:24
b6d0659 to
9bc4e6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we can differentiate between detection errors and data errors that we can then show to the user.
Adds InvalidFeedTypeException and InvalidFeedDataExceptio we use in the feed auto detection to differentiate between errors detecting a feed type and a parsing error.