Skip to content

Chore: [AEA-0000] - remove pushing cdk image #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 5 commits into from
Mar 30, 2026
Merged

Chore: [AEA-0000] - remove pushing cdk image #649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c94c3f8
remove pushing cdk image
anthony-nhs Mar 30, 2026
894bdd1
Merge remote-tracking branch 'origin/main' into remove_cdk_image
anthony-nhs Mar 30, 2026
58f27af
fix workflow
anthony-nhs Mar 30, 2026
2580615
remove unused step
anthony-nhs Mar 30, 2026
c0cf4c3
update readme
anthony-nhs Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 0 additions & 49 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,55 +51,6 @@ jobs:
tag_format: ${{ needs.get_config_values.outputs.tag_format }}
secrets: inherit

package_code:
needs: [tag_release, quality_checks, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_build.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
VERSION_NUMBER: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}

release_dev:
needs: [tag_release, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: dev
VERSION_NUMBER: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: false
DOCKER_IMAGE_TAG: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.DEV_CDK_PUSH_IMAGE_ROLE }}

release_qa:
needs:
[tag_release, release_dev, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: qa
VERSION_NUMBER: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: false
DOCKER_IMAGE_TAG: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.QA_CDK_PUSH_IMAGE_ROLE }}

release_ref:
needs:
[tag_release, release_dev, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: ref
VERSION_NUMBER: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: false
DOCKER_IMAGE_TAG: pre-release-${{ needs.get_commit_id.outputs.sha_short }}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.REF_CDK_PUSH_IMAGE_ROLE }}

package_npm_code:
needs: [quality_checks, get_commit_id, get_config_values]
uses: ./.github/workflows/package_npm_code.yml
Expand Down
51 changes: 0 additions & 51 deletions .github/workflows/docker_image_build.yml
View file
Open in desktop

This file was deleted.

95 changes: 0 additions & 95 deletions .github/workflows/docker_image_upload.yml
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,34 +74,12 @@ jobs:
echo "commit_id=${{ github.sha }}" >> "$GITHUB_OUTPUT"
echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"

package_docker_image:
needs: [get_issue_number, quality_checks, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_build.yml
with:
VERSION_NUMBER: PR-${{ needs.get_issue_number.outputs.issue_number }}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}

package_npm_code:
needs: [quality_checks, get_commit_id, get_config_values]
uses: ./.github/workflows/package_npm_code.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}

Comment thread
anthony-nhs marked this conversation as resolved.
release_docker_image:
needs:
[get_issue_number, package_docker_image, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
AWS_ENVIRONMENT: dev
VERSION_NUMBER: PR-${{ needs.get_issue_number.outputs.issue_number }}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: false
DOCKER_IMAGE_TAG: PR-${{ needs.get_issue_number.outputs.issue_number }}-${{ needs.get_commit_id.outputs.sha_short }}
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.DEV_CDK_PUSH_IMAGE_ROLE }}

tag_release:
needs: [get_commit_id, get_config_values]
uses: NHSDigital/eps-common-workflows/.github/workflows/tag-release-devcontainer.yml@352f15f692c23b18f67215ad858f27b06a878717
Expand Down
77 changes: 0 additions & 77 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,80 +51,3 @@ jobs:
publish_packages: packages/cdkConstructs,packages/deploymentUtils
tag_format: ${{ needs.get_config_values.outputs.tag_format }}
Comment thread
anthony-nhs marked this conversation as resolved.
secrets: inherit
Comment thread
anthony-nhs marked this conversation as resolved.

package_code:
needs: [tag_release, quality_checks, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_build.yml
with:
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}

release_dev:
needs: [tag_release, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: dev
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: true
DOCKER_IMAGE_TAG: ${{needs.tag_release.outputs.version_tag}}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.DEV_CDK_PUSH_IMAGE_ROLE }}

release_qa:
needs:
[tag_release, release_dev, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: qa
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: true
DOCKER_IMAGE_TAG: ${{needs.tag_release.outputs.version_tag}}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.QA_CDK_PUSH_IMAGE_ROLE }}

release_ref:
needs:
[tag_release, release_dev, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: ref
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: true
DOCKER_IMAGE_TAG: ${{needs.tag_release.outputs.version_tag}}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.REF_CDK_PUSH_IMAGE_ROLE }}

release_int:
needs:
[tag_release, release_qa, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: int
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: true
DOCKER_IMAGE_TAG: ${{needs.tag_release.outputs.version_tag}}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.INT_CDK_PUSH_IMAGE_ROLE }}

release_prod:
needs:
[tag_release, release_int, package_code, get_commit_id, get_config_values]
uses: ./.github/workflows/docker_image_upload.yml
with:
pinned_image: ${{ needs.get_config_values.outputs.pinned_image }}
AWS_ENVIRONMENT: prod
VERSION_NUMBER: ${{needs.tag_release.outputs.version_tag}}
COMMIT_ID: ${{ needs.get_commit_id.outputs.commit_id }}
TAG_LATEST: true
DOCKER_IMAGE_TAG: ${{needs.tag_release.outputs.version_tag}}
secrets:
CDK_PUSH_IMAGE_ROLE: ${{ secrets.PROD_CDK_PUSH_IMAGE_ROLE }}
53 changes: 0 additions & 53 deletions docker/Dockerfile
View file
Open in desktop

This file was deleted.

Loading
Loading