added openPage in webpack.config.babel.js#65
Conversation
|
And please follow the commit log structure as shown below. if your commit fixes some issue, then note in the |
naveenkumarsangi
left a comment
There was a problem hiding this comment.
@ScareCROW21 I don't think this'll work. Please check the comments above and proceed.
|
Yes. Didn't see the comments. Will do. |
naveenkumarsangi
left a comment
There was a problem hiding this comment.
Please make the changes noted here.
| @@ -1,11 +1,11 @@ | |||
| import path from 'path'; | |||
| import path from 'path'; | |||
There was a problem hiding this comment.
Unnecessary change. Please drop this.
| hot: true, | ||
| inline: true, | ||
| openPage: 'https://localhost:8000' | ||
|
|
There was a problem hiding this comment.
Drop this newline, please.
| filename: 'bundle.js', | ||
| path: path.resolve(__dirname, 'build', 'client') | ||
| path: path.resolve(__dirname, 'build', 'client'), | ||
| publicPath: "localhost:8080/dev-server/bundle.js" |
There was a problem hiding this comment.
"/dev-server" would be enough. You shouldn't be specifying the entire scheme here.
|
And please never merge master branch into your branches. Keep the commit history linear by rebasing stuff. |
|
And I don't see the need for 6 commits here. We can just do it in two, since it's a minor change. |
|
Also, please use |
|
I made a new PR. Tell me if any changes. |
It doesn't seem to work. What am I doing wrong?