Skip to content

index is proxyed and /dev-server added to output.publicPath#67

Open
ghost wants to merge 1 commit intomasterfrom
unknown repository
Open

index is proxyed and /dev-server added to output.publicPath#67
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 3, 2017

Index is proxyed to localhost:8000
output.publicPath is set to /dev-server

@naveenkumarsangi
Copy link
Copy Markdown
Member

@ScareCROW21, the commit structure is too verbose. Simplify it a bit.

Follow this structure:

Shorlog: Basic Description

Detailed Description for the Commit

Fixes <issue_url>

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 3, 2017

git commit -m "shortlog , detailed description, fixes<issue_url>"
Do you want it to be like this?

I'm new to open source.

@naveenkumarsangi
Copy link
Copy Markdown
Member

No, no, it's different. Try git commit --amend, you'll be presented with an in terminal editor (vim or nano based on your configuration). You can then use it to edit the commit message.

For more details please visit http://api.coala.io/en/latest/Developers/Writing_Good_Commits.html.

@naveenkumarsangi
Copy link
Copy Markdown
Member

@ScareCROW21, Since this is your first contribution to PiZilla, I'm exempting you from the commit message restrictions. But please follow then from the next time.

@naveenkumarsangi
Copy link
Copy Markdown
Member

You'd also need to change the line https://github.com/NITDgpOS/PiZilla/blob/master/server/routes.js#L35
to '/dev-server' + webpackConfig.output.filename for the second parameter to the url.resolve function.

This will let the client work in development mode.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2017

Sorry. Will commit according to the guidelines next time.

routes.js: added '/dev-server' to second parameter in url.resolve

Line #35 is changed to `/dev-server/${webpackConfig.output.filename}`
for the second parameter to the url.resolve function.
This will let the client work in development mode.

Fixes #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants