Skip to content

Final updates from my fork - #28

Open
wood-chris wants to merge 26 commits into
NOC-MSM:mainfrom
wood-chris:main
Open

Final updates from my fork#28
wood-chris wants to merge 26 commits into
NOC-MSM:mainfrom
wood-chris:main

Conversation

@wood-chris

Copy link
Copy Markdown
Collaborator

No description provided.

@jdha
jdha self-requested a review April 7, 2022 09:18

@jdha jdha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: MPICH change is currently left blank as GitHub Actions uses this fact to build both MPICH and openMPI. I think I've updated the comment in the namelist locally to reflect this and will merge back later. So if you could revert this back to MPI =

@jdha jdha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: update an updated version (not yet pushed) I put apt-get -y update on line 54

Comment thread Singularity.nemo Outdated

mkdir /opt/nemo
mv /nemo/nemo/cfgs/NEMO/EXP00/nemo /opt/nemo/
c

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what c is for

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I fixed that in a later commit!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this commit: 9bd8a73

@wood-chris

Copy link
Copy Markdown
Collaborator Author

I think I've resolved all the comments, but let me know if I've missed anything or there's anything that conflicts with anything you've done lately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants