Add v4.2.0, generalise COMPONENTS (i.e. OPA/TOP) and CPP_KEYS - #37
Draft
jpolton wants to merge 57 commits into
Draft
Add v4.2.0, generalise COMPONENTS (i.e. OPA/TOP) and CPP_KEYS#37jpolton wants to merge 57 commits into
jpolton wants to merge 57 commits into
Conversation
Update VERSION
Feature/add gitlab and 4.2
Add NEMO components options and CPP flag options
Update VERSION
Feature/nemo components
pass multi strings as options
pass multi strings as options
pass multi strings as options
jdha
reviewed
Mar 23, 2023
| ;; | ||
| trunk) svn co http://forge.ipsl.jussieu.fr/ioserver/svn/XIOS/branchs/xios-2.5@1964 xios | ||
| ;; | ||
| 4.2.0) svn co http://forge.ipsl.jussieu.fr/ioserver/svn/XIOS/branchs/xios-2.5@1964 xios |
Contributor
There was a problem hiding this comment.
don't use 2.5 ... use something like the following I've added for JMMP/CO_AMM7_4.2:
4.2) svn checkout http://forge.ipsl.jussieu.fr/ioserver/svn/XIOS/trunk@2379 xios
;;
4.2.0) svn checkout http://forge.ipsl.jussieu.fr/ioserver/svn/XIOS/trunk@2379 xios
Author
There was a problem hiding this comment.
I've fixed the namelist reading issues in this branch/PR.
I've left the NEMO / XIOS version edits alone (though reverting to main would help with the merging), pending @jdha modifications already explored.
pass multi strings as options
Update VERSION
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done: Edits to add 4.2.0 via gitlab repo.
WIP: add multiple words to variable definitions in NEMO_in that can be passed to setup_nemo
E.g. this would be ideal
In practise can not find a way to add multiple entries (e.g. key_diainstant AND key_xios) to a variable :-(
NB these two changes can not really be separated as the cpp_keys change with 4.2.0