Skip to content

fix: remove unused imports in jpeg_encoder - #659

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA-AI-IOT:masterfrom
andrewwhitecdw:codequality/jpeg-encoder-remove-unused-imports-in-jpeg-encoder
Open

fix: remove unused imports in jpeg_encoder#659
andrewwhitecdw wants to merge 1 commit into
NVIDIA-AI-IOT:masterfrom
andrewwhitecdw:codequality/jpeg-encoder-remove-unused-imports-in-jpeg-encoder

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR addresses the following issue in jetbot/jpeg_encoder.py: remove unused imports in jpeg_encoder.

Changes

  • jetbot/jpeg_encoder.py: remove unused imports in jpeg_encoder.

Details

--- a/jetbot/jpeg_encoder.py
+++ b/jetbot/jpeg_encoder.py
@@ -1,8 +1,5 @@
-import traitlets
-import gi
-gi.require_version('Gst', '1.0')
-import logging
-import atexit
-import numpy as np
-import time
-from gi.repository import GObject, Gst
+import atexit
+
+import gi
+gi.require_version('Gst', '1.0')
+from gi.repository import Gst

Tests

  • tests/test_jpeg_encoder_imports.py
--- /dev/null
+++ tests/test_jpeg_encoder_imports.py
@@ -0,0 +1,24 @@
+import ast
+import unittest
+from pathlib import Path
+
+
+class TestJpegEncoderImports(unittest.TestCase):
+    def test_unused_imports_removed(self):
+        module_path = Path(__file__).parent.parent / 'jetbot' / 'jpeg_encoder.py'
+        tree = ast.parse(module_path.read_text())
+        imported_names = set()
+        for node in ast.walk(tree):
+            if isinstance(node, ast.Import):
+                for alias in node.names:
+                    imported_names.add(alias.asname or alias.name)
+            elif isinstance(node, ast.ImportFrom):
+                for alias in node.names:
+                    imported_names.add(alias.asname or alias.name)
+        unused = {'traitlets', 'logging', 'numpy', 'time', 'GObject'}
+        self.assertTrue(
+            unused.isdisjoint(imported_names),
+            f\"Previously unused imports are still present: {unused & imported_names}\"
+        )
+
+
+if __name__ == '__main__':
+    unittest.main()

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant