Skip to content

fix: use private files for generated hook commands - #939

Draft
willkill07 wants to merge 9 commits into
NVIDIA:release/0.8from
willkill07:fix/file-backed-hook-commands
Draft

fix: use private files for generated hook commands#939
willkill07 wants to merge 9 commits into
NVIDIA:release/0.8from
willkill07:fix/file-backed-hook-commands

Conversation

@willkill07

Copy link
Copy Markdown
Member

Overview

Generate short native hook commands that load private Relay-owned configuration, preventing Windows command-line overflow without exposing gateway URLs or generation tokens.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Store generated hook settings in versioned private config files.
  • Generate persistent and transparent Codex/Claude Code hooks with --hook-config.
  • Remove generated PowerShell encoded-command envelopes and update migration documentation.

Where should the reviewer start?

Start with crates/cli/src/hooks/config.rs and crates/cli/src/hooks/encoding.rs; they define the private config contract and compact command generation.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to: AEP-94

Signed-off-by: Will Killian <wkillian@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:L PR is large Bug issue describes bug; PR fixes bug lang:rust PR changes/introduces Rust code labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown

@willkill07 willkill07 self-assigned this Aug 28, 2026
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 added this to the 0.9 milestone Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug issue describes bug; PR fixes bug lang:rust PR changes/introduces Rust code size:L PR is large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant