-
Notifications
You must be signed in to change notification settings - Fork 62
feat: add gateway lifecycle controls #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willkill07
wants to merge
5
commits into
NVIDIA:release/0.8
Choose a base branch
from
willkill07:fix/gateway-lifecycle-controls
base: release/0.8
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
91015f2
enhancement: add gateway lifecycle controls
willkill07 ce0c01f
fix: start gateway lifecycle command
willkill07 6d6cf64
test: cover gateway lifecycle commands
willkill07 ce647e3
fix: align gateway start and stop lifecycle
mnajafian-nv f09a1e7
fix: tolerate transient gateway shutdown probes
mnajafian-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| use std::net::SocketAddr; | ||
| use std::process::ExitCode; | ||
|
|
||
| use clap::{Args, Subcommand}; | ||
|
|
||
| use crate::error::CliError; | ||
|
|
||
| use super::serve::ServerArgs; | ||
|
|
||
| pub(super) fn stop_bind(server: &ServerArgs) -> SocketAddr { | ||
| server | ||
| .bind | ||
| .unwrap_or_else(|| crate::configuration::GatewayConfig::default().bind) | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Args)] | ||
| pub(crate) struct GatewayCommand { | ||
| #[command(subcommand)] | ||
| command: GatewaySubcommand, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Subcommand)] | ||
| enum GatewaySubcommand { | ||
| /// Start the gateway with the same server configuration as a bare daemon invocation. | ||
| Start, | ||
| /// Stop the Relay gateway at the configured loopback endpoint. | ||
| Stop, | ||
| } | ||
|
|
||
| impl GatewayCommand { | ||
| /// Returns whether this command only stops an existing gateway. | ||
| pub(crate) fn is_stop(&self) -> bool { | ||
| matches!(self.command, GatewaySubcommand::Stop) | ||
| } | ||
| } | ||
|
|
||
| /// Executes a gateway lifecycle command. | ||
| pub(crate) async fn execute( | ||
| command: GatewayCommand, | ||
| server: &ServerArgs, | ||
| bootstrap_shutdown_token: Option<String>, | ||
| ) -> Result<ExitCode, CliError> { | ||
| match command.command { | ||
| GatewaySubcommand::Start => super::serve_gateway(server, bootstrap_shutdown_token).await, | ||
|
mnajafian-nv marked this conversation as resolved.
|
||
| GatewaySubcommand::Stop => crate::mcp::stop(stop_bind(server)), | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.