Forward-merge release/0.8 into main - #972
Merged
Merged
Conversation
#### Overview Recover managed MCP gateways that stop answering health checks, while making port conflicts actionable in operational logs. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details - Terminate an unhealthy managed gateway, wait one second, then force-kill its detached process tree before bootstrap starts a replacement. - Preserve unmanaged-listener protection and add endpoint, health classification, remediation, and detailed failure context to bootstrap conflict logs. - Add stale-owner and forced-termination regression coverage. - Validated with `just test-rust`, focused bootstrap tests, commit hooks, and `cargo clippy -p nemo-relay-cli --all-targets -- -D warnings`. #### Where should the reviewer start? Start with `crates/cli/src/bootstrap/mod.rs` for bootstrap classification and conflict events, then `crates/cli/src/bootstrap/state.rs` for process termination. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: none ## Summary by CodeRabbit * **Bug Fixes** * Unhealthy managed gateways are now stopped before replacement gateways start. * Stale ownership records for unreachable gateways are cleaned up safely. * Managed gateway cleanup verifies ownership before stopping processes, leaving unowned gateways unaffected. * Gateway processes and related child processes are fully terminated when necessary. * Gateway conflicts and recovery failures now provide clearer diagnostic details, including failure classification and remediation information. Authors: - Will Killian (https://github.com/willkill07) Approvers: - Maryam Najafian (https://github.com/mnajafian-nv) URL: #971
Author
|
SUCCESS - forward-merge complete. |
github-actions
Bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.8 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.