-
Notifications
You must be signed in to change notification settings - Fork 177
Ko TN: Add serial grammar and review fixes #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bbae0312
wants to merge
14
commits into
NVIDIA:staging/ko_tn_v2
Choose a base branch
from
bbae0312:ko-tn-fix
base: staging/ko_tn_v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
98d4da2
Add Korean TN post-processing rules for particle agreement and month …
bbae0312 19619a9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 420fb96
Add Korean TN fraction test cases for particle agreement
bbae0312 ecf34cc
Fix Korean fraction verbalization with particle-aware handling and re…
bbae0312 7acdb88
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f47b370
Fix date and fraction normalization issues based on review feedback
bbae0312 be9a45c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] cbf4bd4
Add Korean TN serial and review fixes
bbae0312 c747daf
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 34b8698
Address Korean TN review feedback
bbae0312 95f08fc
Merge branch 'staging/ko_tn_v2' into ko-tn-fix
bbae0312 33b6c0a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5586dcd
Resolve Korean telephone conflict and remove serial references
bbae0312 7b5ae47
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,7 @@ No. 번호 | |
| ) 오른쪽 괄호 | ||
| + 더하기 | ||
| - 마이너스 | ||
| = 은 | ||
| Σ 시그마 | ||
| η 에타 | ||
| κ 카파 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there no issue with potential 0 leading strings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the full telephone test cases, including leading-zero cases. All 40 tests passed, and the zeros are preserved correctly.