Skip to content

docs(providers): align setup guidance - #434

Open
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:docs/433-provider-setup
Open

docs(providers): align setup guidance#434
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:docs/433-provider-setup

Conversation

@deepujain

Copy link
Copy Markdown
Contributor

Summary

  • Align .env.example, the README provider reference, and the development setup guide with the provider selector on current main.
  • Document the dedicated Ollama, Azure OpenAI, generic OpenAI-compatible, and Gemini CLI setup paths.
  • Preserve existing provider behavior; this PR changes setup guidance only.

Validation

  • Compared every documented provider name, credential variable, endpoint default, and model default against the corresponding implementation under src/skillspector/providers/.
  • Verified all eleven usable provider names and the new provider-specific variables occur in .env.example, README.md, and docs/DEVELOPMENT.md.
  • pytest -m 'not integration and not provider' tests/ -q — 2,825 passed, 13 skipped, 38 deselected, 4 xfailed.
  • ruff check src tests — passed.
  • ruff format --check src tests — 193 files already formatted.
  • git diff --check — passed.
  • Inspected the Markdown tables and fenced setup examples in source; no local Markdown renderer is configured in the repository.

Risk

  • Low: documentation and the example environment template only; runtime provider selection and request behavior are unchanged.
  • Live-provider tests were not run because no provider code changed.

Fixes #433

Signed-off-by: Deepak Jain <deepujain@gmail.com>
@deepujain
deepujain force-pushed the docs/433-provider-setup branch from 8cf2c56 to b62550f Compare August 25, 2026 22:11

@rng1995 rng1995 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[SkillSpector Review]

The added provider setup paths otherwise match their implementations, but the table would still advertise nv_build's retired default after merging into current main. Please update that model reference so the setup documentation is actually aligned. All required checks are green.

Comment thread README.md
@@ -236,8 +236,12 @@ inference gateways.
| `anthropic_proxy` | `ANTHROPIC_PROXY_API_KEY` + `ANTHROPIC_PROXY_ENDPOINT_URL` | Any Vertex-style raw-predict proxy | `claude-sonnet-4-6` |
| `bedrock` | `AWS_PROFILE` (optional) + `AWS_REGION` — SigV4 via boto3 | AWS Bedrock Runtime | `us.anthropic.claude-sonnet-4-6-20250915-v1:0` |
| `nv_build` | `NVIDIA_INFERENCE_KEY` | build.nvidia.com | `deepseek-ai/deepseek-v4-flash` |

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Update the nv_build default while aligning this table. On current main, NvBuildProvider.DEFAULT_MODEL is z-ai/glm-5.2; the old deepseek-v4-flash is explicitly retired and returns 410. This PR merges cleanly without changing this row, so the newly aligned provider table would still advertise a dead default. Change this cell to z-ai/glm-5.2 and update any copied default references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provider setup docs omit supported backends

2 participants