Skip to content

feat(cli): add fail-on-findings option - #469

Open
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:feat/448-fail-on-findings
Open

feat(cli): add fail-on-findings option#469
deepujain wants to merge 1 commit into
NVIDIA:mainfrom
deepujain:feat/448-fail-on-findings

Conversation

@deepujain

Copy link
Copy Markdown
Contributor

Summary

  • add an opt-in --fail-on-findings gate for active findings below the aggregate risk threshold
  • apply the gate to single and recursive scans after reports are written
  • cover the low-risk single-scan and recursive cases

Validation

  • ruff format --check src/skillspector/cli.py tests/unit/test_cli.py
  • ruff check src/skillspector/cli.py tests/unit/test_cli.py
  • git diff --check
  • python3 -m py_compile src/skillspector/cli.py tests/unit/test_cli.py
  • focused pytest could not collect locally because the temporary Python environment did not retain package metadata; CI is the remaining test surface

Fixes #448

Signed-off-by: Deepak Jain deepujain@gmail.com

Signed-off-by: Deepak Jain <deepujain@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] An easy method to have skillspector to exit with an error if theres findings

1 participant